Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if not necessary to sort settings lists #8573

Merged
merged 3 commits into from Mar 2, 2021
Merged

check if not necessary to sort settings lists #8573

merged 3 commits into from Mar 2, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Feb 28, 2021 •
edited by czoido

Changelog: Fix: Do not order Settings lists, so error messages are in declared order.
Docs: Omit

Lets see if this doesn't break anything...

Close #8571

@memsharded memsharded mentioned this pull request Feb 28, 2021
Closed
@memsharded memsharded added this to the 1.35 milestone Feb 28, 2021
jgsogo
jgsogo approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the tests work, I see no reason to modify the order from settings.yml

@jgsogo jgsogo merged commit 36d0a07 into conan-io:develop Mar 2, 2021
@memsharded memsharded deleted the feature/unorder_settings_lists branch March 2, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@jgsogo jgsogo jgsogo approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.

Unlucky sorting of "Possible values are..." error message
3 participants
@memsharded @SSE4 @jgsogo