wip - add WSL and SSH remotes #16109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsanfal
force-pushed
the
feature/docker_wrapper
branch
4 times, most recently
from
931087b
to
8fecd97
Compare
memsharded
reviewed
Apr 22, 2024
| @@ -0,0 +1,11 @@ | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
The 3 dockerfiles are almost identical, isn't it possible to layer them so testing with them is cheaper (faster images to build)?
Comment on lines
+77
to
+84
| settings = "build_type", "compiler" | ||
| author = "John Doe" | ||
| license = "MIT" | ||
| url = "https://foo.bar.baz" | ||
| homepage = "https://foo.bar.site" | ||
| topics = "foo", "bar", "qux" | ||
| provides = "libjpeg", "libjpg" | ||
| deprecated = "other-pkg" |
There was a problem hiding this comment.
Most of the metadata, unless used in the test, can be removed to simplify the recipe.
Comment on lines
+137
to
+144
| settings = "build_type", "compiler" | ||
| author = "John Doe" | ||
| license = "MIT" | ||
| url = "https://foo.bar.baz" | ||
| homepage = "https://foo.bar.site" | ||
| topics = "foo", "bar", "qux" | ||
| provides = "libjpeg", "libjpg" | ||
| deprecated = "other-pkg" |
| @pytest.mark.parametrize("build_type,shared", [("Release", False), ("Debug", True)]) | ||
| @pytest.mark.tool("ninja") | ||
| def test_create_docker_runner_with_ninja(build_type, shared): | ||
| conanfile = textwrap.dedent(""" |
There was a problem hiding this comment.
Why not using a built-in conan new cmake_lib template?
Comment on lines
+64
to
+68
| return { | ||
| 'docker': DockerRunner, | ||
| 'ssh': SSHRunner, | ||
| 'wsl': WSLRunner, | ||
| }[profile_host.runner.get('type')](conan_api, 'create', profile_host, profile_build, args, raw_args).run() |
There was a problem hiding this comment.
Suggested change
| return { | |
| 'docker': DockerRunner, | |
| 'ssh': SSHRunner, | |
| 'wsl': WSLRunner, | |
| }[profile_host.runner.get('type')](conan_api, 'create', profile_host, profile_build, args, raw_args).run() | |
| try: | |
| runner_class = { 'docker': DockerRunner, 'ssh': SSHRunner, 'wsl': WSLRunner}[profile_host.runner.get('type')] | |
| except KeyError: | |
| raise ConanException(f"Unrecognized runner 'type'={profile_host.runner.get('type')}") | |
| runner = runner_class(conan_api, 'create', profile_host, profile_build, args, raw_args) | |
| return runner.run() |
A bit more UX-friendly ready, as users will miss or mistype the type.
davidsanfal
force-pushed
the
feature/docker_wrapper
branch
2 times, most recently
from
a81379f
to
07232cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.