New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CONAN_RUNTIME_LIB_DIRS to the conan_toolchain.cmake #15914
base: develop2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make the libdirs
multi-config with a generator expression, as done with MSVC_RUNTIME
and flags? It would be important for VS, otherwise it might be failing and collecting Debug runtime libs even if in a Release build, just because Debug configuration was the last installed one.
conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
Outdated
Show resolved
Hide resolved
conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
Outdated
Show resolved
Hide resolved
conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
Outdated
Show resolved
Hide resolved
conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
Outdated
Show resolved
Hide resolved
conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that it would be important to make CONAN_RUNTIME_LIB_DIRS a generator expression for multi-config systems, or at least a _RELEASE, _DEBUG one. There is risk of bringing the wrong runtime just because -s build_type=Debug
was executed last.
indeed! This was a further step - we first need to check whether the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better, getting close, just a couple of minor comments.
The changes in this PR cause a warning to be issued:
I can get it to not show that warning by doing semi-colon The
the |
Changelog: Feature: Add
CONAN_RUNTIME_LIB_DIRS
variable to theconan_toolchain.cmake
Docs: conan-io/docs#3698
Close: #15810