Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC][feature] find_libraries function #15866

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

[POC][feature] find_libraries function #15866

wants to merge 8 commits into from

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Mar 13, 2024 •
edited

Changelog: Feature: Created find_libraries function (alternative to collect_libs).
Docs: https://github.com/conan-io/docs/pull/XXXX

@franramirez688 franramirez688 added this to the 2.2.0 milestone Mar 13, 2024
@franramirez688 franramirez688 modified the milestones: 2.2.0, 1.64 Mar 13, 2024
@franramirez688 franramirez688 changed the base branch from develop2 to develop March 13, 2024 15:48
memsharded
memsharded reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I now understand better the intent of this :)

My main comment is that I think we want to do this together with a re-design of the cpp_info capabilities (CPS-like) for defining libraries more explicitly, including types, import-libs and details like that

conan/tools/files/files.py
from urllib.parse import urlparse
from urllib.request import url2pathname

import six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No six import should be necessary anymore! I thought we had gotten rid of this 😅

@franramirez688 franramirez688 mentioned this pull request Mar 14, 2024
Draft
@franramirez688 franramirez688 modified the milestones: 1.64, 2.3.0 Mar 26, 2024
@franramirez688 franramirez688 changed the title [POC][feature] fetch_libraries function [POC][feature] find_libraries function Apr 26, 2024
@memsharded memsharded modified the milestones: 2.3.0, 2.4.0 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franramirez688 @memsharded