Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Detect if running clang compiler on Windows #12241

Closed
wants to merge 1 commit into from

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Oct 4, 2022

Changelog: Feature: conan.tools.microsoft.is_clang_cl detects if running Clang on Windows
Docs: conan-io/docs#2774

close #12175

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid this is no longer valid. The clangCL is nothing specific anymore, and is not part of the new msvc compiler either, the right compiler is clang, with generator Visual Studio.

Check: #11492

@uilianries
Copy link
Member Author

Closing this one. With #11492 is clear that a generic check for CLang on Windows will not work for many cases. So far, 3% of CCI recipes need to validate clang on Windows, but we don't have a clear situation about which clang and its version. It will be better analyzing each case there and consider the new proposal from #11492.

@uilianries uilianries closed this Oct 4, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 30, 2022

Is it more clear now that #11492 has been merged? 3% of CCI recipes try to manage clang CL or a mingw clang flavor, but many more are broken and would need better detection of clang CL.

It would also be nice to have a is_mingw() (because it can be gcc targeting Windows, or a clang flavor targeting windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Recognize Clang CL on Windows as tool method
3 participants