Bugfixes 11743 and 11755 #11756
Bugfixes 11743 and 11755 #11756
Conversation
| @@ -121,6 +109,9 @@ def template(self): | |||
| $<$<CONFIG:{{configuration}}>:${{'{'}}{{pkg_name}}_LIB_DIRS{{config_suffix}}}> APPEND) | |||
| {%- endif %} | |||
|
|
|||
| # For the modules (FindXXX) | |||
| list(APPEND {{ pkg_name }}_LIBRARIES{{ config_suffix }} {{root_target_name}}) | |||
There was a problem hiding this comment.
Note, here I'm attaching the target instead of the path to the libraries, like in previous versions. That is because the macro conan_package_library_targets was simplified and only returns the targets.
When someone uses the Boost_LIBRARIES is typically to link a target with them so it should be ok and it is wide easier in code, and also, the transitive dependencies of the package were always added as targets to the list.
| @@ -174,9 +168,7 @@ def template(self): | |||
|
|
|||
| ########## AGGREGATED GLOBAL TARGET WITH THE COMPONENTS ##################### | |||
| {%- for comp_variable_name, comp_target_name in components_names %} | |||
|
|
|||
| target_link_libraries({{root_target_name}} INTERFACE {{ comp_target_name }}) | |||
There was a problem hiding this comment.
This is what it was causing the #11755 error. When using an add_subdirectory the target exists but fails to use target_link_libraries. This is apparently related to the scope of the target. Creating the targets as INTERFACE GLOBAL worked too but looked more dangerous.
| t.run("install .") | ||
| # only doing the configure failed before #11743 fix | ||
| t.run("build .") | ||
| assert "AGGREGATED LIBS: boost::B;boost::A" in t.out |
There was a problem hiding this comment.
These are the targets, in previous versions of Conan in that variable appeared the path to the libraries files, except for the dependencies that were also targets and are kept as targets
Changelog: Bugfix: The CMakeDeps generator failed for consumers with CMake projects doing an
add_subdirectorywith two differentfind_packagecalls to the same package, one in the mainCMakeLists.txtand the other in the subdirectory.Changelog: Bugfix: The CMakeDeps generator stopped to fill the
XXX_LIBRARIESCMake variable, especially when using components.Docs: omit
Close #11755
Close #11743