New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package_manager: fix opensuse detection #11660
Conversation
cf #3368 |
Hi @ericLemanissier, |
@@ -37,7 +37,7 @@ def get_default_tool(self): | |||
"brew": ["Darwin"], | |||
"pacman": ["arch", "manjaro", "msys2"], | |||
"choco": ["Windows"], | |||
"zypper": ["opensuse", "sles"], | |||
"zypper": ["opensuse", "sles", "opensuse-tumbleweed"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding "opensuse-tumbleweed"
as the distro related to zypper should solve the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3368 mentions opensuse-leap
, and I have no idea what are the names for sles
. This is why I chose to keep the behaviour of conans/client/tools/oss.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I see, we can do some mix of both, and also test opensuse-leap
and make sure that in the future if one distro returns opensuse-newversion
it will not break...
Changelog: Fix: Improve opensuse detection in
tool.system.package_manager
.Docs: omit
For example, on opensuse tumbleweed, the distro name is
opensuse-tumbleweed
this re-implements what was done in
conan/conans/client/tools/oss.py
Line 230 in f921551
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.