Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MesonToolchain] Added Objective-C/C++ arguments #11632

Merged
merged 2 commits into from Jul 14, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 28 additions & 1 deletion conan/tools/meson/toolchain.py
Expand Up @@ -40,6 +40,8 @@ class MesonToolchain(object):
[binaries]
{% if c %}c = '{{c}}'{% endif %}
{% if cpp %}cpp = '{{cpp}}'{% endif %}
{% if objc %}objc = '{{objc}}'{% endif %}
{% if objcpp %}objcpp = '{{objcpp}}'{% endif %}
{% if c_ld %}c_ld = '{{c_ld}}'{% endif %}
{% if cpp_ld %}cpp_ld = '{{cpp_ld}}'{% endif %}
{% if ar %}ar = '{{ar}}'{% endif %}
Expand All @@ -57,11 +59,17 @@ class MesonToolchain(object):
{% if b_staticpic %}b_staticpic = {{b_staticpic}}{% endif %}
{% if cpp_std %}cpp_std = '{{cpp_std}}' {% endif %}
{% if backend %}backend = '{{backend}}' {% endif %}
{% if pkg_config_path %}pkg_config_path = '{{pkg_config_path}}'{% endif %}
# C/C++ arguments
c_args = {{c_args}} + preprocessor_definitions + deps_c_args
c_link_args = {{c_link_args}} + deps_c_link_args
cpp_args = {{cpp_args}} + preprocessor_definitions + deps_cpp_args
cpp_link_args = {{cpp_link_args}} + deps_cpp_link_args
{% if pkg_config_path %}pkg_config_path = '{{pkg_config_path}}'{% endif %}
# Objective-C/C++ arguments
objc_args = {{objc_args}} + preprocessor_definitions + deps_c_args
objc_link_args = {{objc_link_args}} + deps_c_link_args
objcpp_args = {{objcpp_args}} + preprocessor_definitions + deps_cpp_args
objcpp_link_args = {{objcpp_link_args}} + deps_cpp_link_args

{% for context, values in cross_build.items() %}
[{{context}}_machine]
Expand Down Expand Up @@ -160,6 +168,13 @@ def __init__(self, conanfile, backend=None):
self.c_link_args = self._get_env_list(build_env.get("LDFLAGS", []))
self.cpp_args = self._get_env_list(build_env.get("CXXFLAGS", []))
self.cpp_link_args = self._get_env_list(build_env.get("LDFLAGS", []))
# Objective C/C++ ones
self.objc = "clang"
franramirez688 marked this conversation as resolved.
Show resolved Hide resolved
self.objcpp = "clang++"
self.objc_args = self._get_env_list(build_env.get('OBJCFLAGS', []))
self.objc_link_args = self._get_env_list(build_env.get('LDFLAGS', []))
self.objcpp_args = self._get_env_list(build_env.get('OBJCXXFLAGS', []))
self.objcpp_link_args = self._get_env_list(build_env.get('LDFLAGS', []))

# Apple flags
self.apple_arch_flag = []
Expand Down Expand Up @@ -238,6 +253,12 @@ def _context(self):
self.cpp_args.extend(apple_flags + extra_flags["cxxflags"])
self.c_link_args.extend(apple_flags + extra_flags["ldflags"])
self.cpp_link_args.extend(apple_flags + extra_flags["ldflags"])
# Objective C/C++
self.objc_args.extend(self.c_args)
self.objcpp_args.extend(self.cpp_args)
# These link_args have already the LDFLAGS env value so let's add only the new possible ones
self.objc_link_args.extend(apple_flags + extra_flags["ldflags"])
self.objcpp_link_args.extend(apple_flags + extra_flags["ldflags"])

return {
# https://mesonbuild.com/Machine-files.html#properties
Expand All @@ -250,6 +271,8 @@ def _context(self):
# https://mesonbuild.com/Reference-tables.html#compiler-and-linker-selection-variables
"c": self.c,
"cpp": self.cpp,
"objc": self.objc,
"objcpp": self.objcpp,
"c_ld": self.c_ld,
"cpp_ld": self.cpp_ld,
"ar": self.ar,
Expand All @@ -271,6 +294,10 @@ def _context(self):
"c_link_args": to_meson_value(self._filter_list_empty_fields(self.c_link_args)),
"cpp_args": to_meson_value(self._filter_list_empty_fields(self.cpp_args)),
"cpp_link_args": to_meson_value(self._filter_list_empty_fields(self.cpp_link_args)),
"objc_args": to_meson_value(self._filter_list_empty_fields(self.objc_args)),
"objc_link_args": to_meson_value(self._filter_list_empty_fields(self.objc_link_args)),
"objcpp_args": to_meson_value(self._filter_list_empty_fields(self.objcpp_args)),
"objcpp_link_args": to_meson_value(self._filter_list_empty_fields(self.objcpp_link_args)),
"pkg_config_path": self.pkg_config_path,
"preprocessor_definitions": self.preprocessor_definitions,
"cross_build": self.cross_build
Expand Down
110 changes: 110 additions & 0 deletions conans/test/functional/toolchains/meson/test_meson_and_objc.py
@@ -0,0 +1,110 @@
import os
import platform
import sys
import textwrap

import pytest

from conans.client.tools.apple import XCRun, to_apple_arch
from conans.test.utils.tools import TestClient

_conanfile_py = textwrap.dedent("""
from conan import ConanFile
from conan.tools.meson import Meson, MesonToolchain


class App(ConanFile):
settings = "os", "arch", "compiler", "build_type"
options = {"shared": [True, False], "fPIC": [True, False]}
default_options = {"shared": False, "fPIC": True}

def layout(self):
self.folders.build = "build"

def config_options(self):
if self.settings.os == "Windows":
del self.options.fPIC

def generate(self):
tc = MesonToolchain(self)
tc.generate()

def build(self):
meson = Meson(self)
meson.configure()
meson.build()
""")

_meson_build_objc = textwrap.dedent("""
project('tutorial', 'objc')
executable('demo', 'main.m')
""")


@pytest.mark.parametrize("arch, os_, os_version, sdk", [
('armv8', 'iOS', '10.0', 'iphoneos'),
('armv7', 'iOS', '10.0', 'iphoneos'),
('x86', 'iOS', '10.0', 'iphonesimulator'),
('x86_64', 'iOS', '10.0', 'iphonesimulator'),
('armv8', 'Macos', None, None) # MacOS M1
])
@pytest.mark.tool_meson
@pytest.mark.skipif(sys.version_info.major == 2, reason="Meson not supported in Py2")
@pytest.mark.skipif(platform.system() != "Darwin", reason="requires Xcode")
def test_apple_meson_toolchain_cross_compiling_and_objective_c(arch, os_, os_version, sdk):
profile = textwrap.dedent("""
include(default)

[settings]
os = {os}
os.version = {os_version}
os.sdk = {os_sdk}
arch = {arch}
compiler = apple-clang
compiler.version = 12.0
compiler.libcxx = libc++

[buildenv]
LDFLAGS=-framework Foundation
franramirez688 marked this conversation as resolved.
Show resolved Hide resolved

[conf]
tools.apple:sdk_path={sdk_path}
""")

xcrun = XCRun(None, sdk)
sdk_path = xcrun.sdk_path
app = textwrap.dedent("""
#import <Foundation/Foundation.h>

int main(int argc, const char * argv[]) {
@autoreleasepool {
// insert code here...
NSLog(@"Hello, World!");
}
return 0;
}
""")
profile = profile.format(
os=os_,
os_version=os_version,
os_sdk=sdk,
arch=arch,
sdk_path=sdk_path)

t = TestClient()
t.save({"conanfile.py": _conanfile_py,
"meson.build": _meson_build_objc,
"main.m": app,
"profile_host": profile})

t.run("install . --profile:build=default --profile:host=profile_host")
t.run("build .")
assert "Objective-C compiler for the host machine: clang" in t.out
assert "Objective-C compiler for the build machine: cc" in t.out
franramirez688 marked this conversation as resolved.
Show resolved Hide resolved

demo = os.path.join(t.current_folder, "build", "demo")
assert os.path.isfile(demo) is True
franramirez688 marked this conversation as resolved.
Show resolved Hide resolved

lipo = xcrun.find('lipo')
t.run_command('"%s" -info "%s"' % (lipo, demo))
assert "architecture: %s" % to_apple_arch(arch) in t.out