New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MesonToolchain] Adding default dirs #11618
[MesonToolchain] Adding default dirs #11618
Conversation
@@ -45,6 +45,8 @@ def install(self): | |||
self._conanfile.run(cmd) | |||
|
|||
def test(self): | |||
if self._conanfile.conf.get("tools.build:skip_test"): | |||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing these lines from new Meson build-helper
it would be helpful to add some test/example on how to use |
The |
yeah, as I have figured it out from https://docs.conan.io/en/latest/reference/conanfile/tools/layout.html?highlight=basic_layout#basic-layout:
and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
install_data(['src/file1.txt', 'src/file2.txt']) | ||
""") | ||
# Replace meson.build | ||
self.t.save({"meson.build": _meson_build, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if so much replace of the initial template is going to happen, then maybe it is worth to define things here?
I am also happy if we add the install
bit to the meson
templates, for example, adding a License, and making sure that the install is packaging the license too?
284e9ee
to
9c6d86f
Compare
Changelog: Feature: Adding default directories to MesonToolchain.
Docs: conan-io/docs#2652
Closes: #9713
Closes: #11596
Note: Using the
basic_layout
seems to be enough for now.