New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to reference files in the local filesystem with file:// s… #11569
Changes from 2 commits
866417b
a182818
130b588
9b7f613
cf24294
db618c9
c3f820e
4e8508b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
pytest>=6.1.1, <7.0.0; python_version > '3.0' | ||
pytest>=4.6.11; python_version < '3.0' | ||
pytest-xdist # To launch in N cores with pytest -n | ||
pyfakefs>=4.5.6 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd say definitely not worth the complexities and problems for using more third parties, for this very specific use case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I didn't realize it was There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, just used for testing! I exposes an in-memory filesystem to tests such that python functions that operate on the filesystem read from this instead. For the purposes of this test, writing a temp file on the actual file system and reading back is also an option. I wanted to a be a little more explicit making sure that paths like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd say yes, we already do a ton of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! Still does the job :D |
||
parameterized>=0.6.3 | ||
mock>=1.3.0, <1.4.0 | ||
WebTest>=2.0.18, <2.1.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still wonder if this is the best place to do it - we'd have to ignore
retry
,retry_wait
,auth
andheaders
, but still have to check the checksums and overwrite! (working on it!)The best alternative would be:
conans/client/downloaders/file_downloader.py