Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Improve dependency-cycle error to show the cycle #11519

Merged

Commits on Jun 24, 2022

  1. Improve dependency-cycle error to show the cycle

    Original message isn't help when diagnosing problems with a recipe...
    Now it will print out all the X->Y dependencies that remain after the
    irrelevant components have been eliminated.
    
    Within that list will be the problematic cycle.
    
    For example, as a test I introduced a cycle into my prototype VTK recipe,
    
    I added:
    self.cpp_info.components["vtksys"].requires.append("CommonDataModel")
    
    The cycle would be:
    vtksys -> CommonDataModel -> CommonCore -> vtksys
    
    The message was a bit more verbose than that, but enough to be helpful:
    
    ERROR: There is a dependency loop in 'self.cpp_info.components' requires:
       CommonTransforms requires CommonMath
       CommonDataModel requires CommonCore
       CommonMath requires CommonCore
       CommonCore requires vtksys
       CommonTransforms requires CommonCore
       CommonCore requires kwiml
       CommonDataModel requires CommonMath
       vtksys requires CommonDataModel
       CommonDataModel requires CommonTransforms
       CommonMath requires kissfft
    paulharris committed Jun 24, 2022
    Copy the full SHA
    4b8df09 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Copy the full SHA
    aec4099 View commit details
    Browse the repository at this point in the history
  2. add test

    memsharded committed Jun 28, 2022
    Copy the full SHA
    6bac857 View commit details
    Browse the repository at this point in the history