fix abuse of Conan attributes in fftw #23792
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
There was a problem hiding this comment.
LGTM
The resulting contents are the same before and after:
├── conaninfo.txt
├── conanmanifest.txt
├── include
│ ├── fftw3.f
│ ├── fftw3.f03
│ ├── fftw3.h
│ ├── fftw3l.f03
│ └── fftw3q.f03
├── lib
│ ├── libfftw3.a
│ ├── libfftw3f.a
│ └── libfftw3l.a
└── licenses
└── COPYRIGHT
|
|
||
| # Potentially avoid side effects due to build_folder property tweak. | ||
| self._current_precision = None | ||
| cmake.install() |
There was a problem hiding this comment.
I think the proposed approach makes sense: files are added to the install folder (the libraries), and every other file is just overwritten with exactly the same contents. This is equivalent to the way it's done in CMake to support multi-configuration (Release/Debug) in the same install tree: configure twice, build twice, install twice to same location.
Was wondering if it would be worth passing --fresh to CMake configure, or clearing the build folder ahead of starting, but from what I can see, we wouldn't benefit much, as the result is the same.
Specify library name and version: fftw
This recipe is abusing the
build_folder, overwriting it. According to the docs: https://docs.conan.io/2/reference/conanfile.htmlThe changes proposed seems to both simplify the recipe and avoid this issue.
This was originated in conan-io/conan#16166, as recent changes in
develop2makes the-DCMAKE_TOOLCHAIN_PATHdefined in Presets at generation time relative between build-folder and generators-folder, but ifbuild_folderis changed under the hood, things do not longer match.Close conan-io/conan#16166