fix abuse of Conan attributes in fftw #23792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: fftw
This recipe is abusing the
build_folder
, overwriting it. According to the docs: https://docs.conan.io/2/reference/conanfile.htmlThe changes proposed seems to both simplify the recipe and avoid this issue.
This was originated in conan-io/conan#16166, as recent changes in
develop2
makes the-DCMAKE_TOOLCHAIN_PATH
defined in Presets at generation time relative between build-folder and generators-folder, but ifbuild_folder
is changed under the hood, things do not longer match.Close conan-io/conan#16166