Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add armv8 support to MSBuildDeps generator #11504

Closed
1 task done
cognomen opened this issue Jun 22, 2022 · 0 comments · Fixed by #11505
Closed
1 task done

[feature] Add armv8 support to MSBuildDeps generator #11504

cognomen opened this issue Jun 22, 2022 · 0 comments · Fixed by #11505
Labels
type: feature
Milestone
1.50

Comments

@cognomen
Copy link

cognomen commented Jun 22, 2022 •
edited

Map armv8 arch to MSBuild ARM64 platform

PR to follow.

Passing -g MSBuildDeps -s arch=armv8 to conan install results in errors of the form:

conanfile.txt: ERROR: Traceback (most recent call last):
  File "xxx\venv\lib\site-packages\conans\client\generators\__init__.py", line 177, in write_generators
    generator.generate()
  File "xxx\venv\lib\site-packages\conan\tools\microsoft\msbuilddeps.py", line 128, in generate
    raise ConanException("MSBuildDeps.platform is None, it should have a value")
conans.errors.ConanException: MSBuildDeps.platform is None, it should have a value

ERROR: Error in generator 'MSBuildDeps': MSBuildDeps.platform is None, it should have a value
markferry pushed a commit to cognomen/conan that referenced this issue Jun 22, 2022
MSBuildDeps: map armv8 to ARM64 platform (conan-io#11504)
8f0a9fc
@franramirez688 franramirez688 linked a pull request Jun 22, 2022 that will close this issue
MSBuildDeps: map armv8 to ARM64 platform (#11504) #11505
Merged
5 tasks
@franramirez688 franramirez688 added this to the 1.50 milestone Jun 22, 2022
markferry pushed a commit to cognomen/conan that referenced this issue Jun 22, 2022
MSBuildDeps: map armv7 to ARM platform (conan-io#11504)
e90c2e3
markferry pushed a commit to cognomen/conan that referenced this issue Jun 23, 2022
MSBuildDeps: map armv7 and armv8 msbuild platforms
37aa6ad 
Fixes conan-io#11504
markferry pushed a commit to cognomen/conan that referenced this issue Jun 27, 2022
MSBuildDeps: map armv7 and armv8 msbuild platforms
f93d7c7 
Fixes conan-io#11504
memsharded added a commit that referenced this issue Jun 28, 2022
@markferry @memsharded
MSBuildDeps: map armv8 to ARM64 platform (#11504) (#11505)
fa52c51 
* fix: x86 msbuild platform is Win32, not x86

* MSBuildDeps: map armv7 and armv8 msbuild platforms

Fixes #11504

* fixed MSBuildDeps Win32 usage

* test: msbuilddeps mapping of arch to platform

* fixup: remove incorrect test description

Co-authored-by: Mark Ferry <mark@cognomen.co.uk>
Co-authored-by: memsharded <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
1.50
Development

Successfully merging a pull request may close this issue.

MSBuildDeps: map armv8 to ARM64 platform (#11504) cognomen/conan
1 participant
@franramirez688