MSBuildDeps: map armv8 to ARM64 platform (#11504)

[markferry]

Changelog: Feature: map armv8 arch to ARM64 MSBuild platform in MSBuildDeps generator.

Docs: Omit

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[CLAassistant]

All committers have signed the CLA.

[markferry]

Needs a testcase...

[memsharded]

Thanks for contributing.

Better please add the full one:

{"x86": "Win32",
                    "x86_64": "x64",
                    "armv7": "ARM",
                    "armv8": "ARM64"}.get(...)

There is an instance of this in CMakeToolchain, maybe we should factorize it (but that can be done later, just focus on getting this right).

For tests, it is enough to add an integration test, don't hesitate to ask for guidance if you need it.

[markferry]

There is an instance of this in CMakeToolchain, maybe we should factorize it (but that can be done later, just focus on getting this right).

Yup, seems beyond a reasonable refactoring threshold:

conan/tools/cmake/toolchain/blocks.py :747 col 31| "armv8": "ARM64"}.get(arch)
conan/tools/microsoft/msbuild.py:16 col 23| 'armv8': 'ARM64'}.get(str(arch))
conans/client/build/cmake_flags.py:104 col 27| "armv8": "ARM64"}.get(arch)
conans/client/build/msbuild.py:61 col 79| msvc_arch = {'x86': 'x86', 'x86_64': 'x64', 'armv7': 'ARM', 'armv8': 'ARM64'}
conans/client/build/msbuild.py:136 col 32| 'armv8': 'ARM64'}
conans/test/functional/layout/test_build_system_layout_helpers.py:38 col 46| subfolders_arch = {"armv7": "ARM", "armv8": "ARM64", "x86": None, "x86_64": "x64"}

[memsharded]

Suggested change

	return {'x86': 'x86',
	return {'x86': 'Win32',

I think this is the right one, and the reason the unit test is failing

[markferry]

🤦

[memsharded]

You also need to check the CLA signing above, please

[markferry]

Testcase to follow.

[markferry]

Testcase to follow.

Will pick this up again on Monday

[markferry]

For tests, it is enough to add an integration test, don't hesitate to ask for guidance if you need it.

Something like this fd48992?

[memsharded]

For tests, it is enough to add an integration test, don't hesitate to ask for guidance if you need it.

Something like this fd48992?

Yes, looks good!

[markferry]

Looks like it died: https://ci.conan.io/blue/organizations/jenkins/ConanTestSuite/detail/PR-11505/8/pipeline/37

[memsharded]

Yes, don't worry, already merged, it will be in 1.50.
Thanks very much for contributing to Conan!