Skip to content

Commit

Permalink
removing pylint from conan codebase. (#6152)
Browse files Browse the repository at this point in the history
* removing pylint from conan codebase. TODO: Move to hooks

* add python_requires to 'conans'

* Fix SyntaxWarning in Python 3.8 (#6165)

* - generate ConfigVersion.cmake file (#6063)

Signed-off-by: SSE4 <tomskside@gmail.com>

* Fixes #5925 Make the first line from find program as the result (#6039)

* 3. extra separator in Windows

* Improve the error message when failed to connect to remote

* Improve the error message when failed to connect to remote

* Improve the error message when failed to connect to remote

* Revert unwanted changes

* Pick the first match which is the best match

* Pick the first match which is the best match

* make reversed explicit (better that [::-1])

* Fix output folder for conanworkspace.cmake when rebuilding dependencies (#6060)

* Added required = True to subparsers in order to print error message in Py2 and Py3.

* sync

* basic concurrent upload at reference level with futures

* revert changes

* add line

* Lock buggy urllib3 (#5808)

* app simplifying (#5806)

* Apply lockfile before updating downstream requires (#5771)

* apply graph_lock before looking for overrides

* first step: get rid of the warning

* cleaner if graph_lock is passed to the function

* only update requires upstream if no lockfile is applied

* fix tests

* Deprecation of CONAN_USERNAME and CONAN_CHANNEL: fix error message (#5756)

* if CONAN_USERNAME and CONAN_CHANNEL are deprecated, the error cannot recommend them

* update tests accordingly

* test client load() file method (#5815)

* no user/channel repr without _ (#5817)

* no user/channel repr without _

* minor fixes

* fix tests

* Remove py34 (#5820)

* fix upload package id (#5824)

* - update macOS, watchOS, tvOS, iOS version numbers (#5823)

* Refresh token client support.  (#5662)

* Refresh token client support. Missing tests. Missing migration

* public method

* WIP

* Refresh almost there

* Removed prints

* Try migrate

* Migration

* Add comment

* Refresh token flow following RFC recommentations

* Refresh ok

* review

* Remove traces

* Refactor capabilities

* Removed tmp file

* Review

* #5819 Show warning message for Python 3.4 (#5829)

* #5819 Show warning message for Python 3.4

- Add new warning message for python 3.4 which is no longer supported
- Added funcional tests to validate both python 3.4 and 2.x

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5819 Fix broken tests

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Add cpp_info.name to cmake and pkg_config generators (#5598)

* Add cpp_info.name to cmake generators

* Fix unit tests to mimic real behavior

* cmake_paths test

* add test for cmake generator

* Add cmake_find_package test

* fix test in py3

* Applied cpp_info.name to pkg_config generator

* check different name in pkg_config

* sync with develop

* save conanworkspace.cmake relative to base folder

* add test

* siplify test

* add context manager to build folder

* change indent

* Publish 'artifacts.properties' using matrix params (#6014)

* draft to test

* add missing argument to functions

* rename 'put_headers' to 'artifact_properties'

* store matrix params as the preformatted string in the router

* fallback to empty string

* something going wrong: too many cchanges

* at least these are not needed

* typo

* it was only needed to remove the matrix_params for the bottle server

* soooo

* remove class name

* fix minor bug

* now with revisions too

* make docs with triple double quotes

* we need to modify the conan_server to accept matrix_params too

* fix tests

* add tests with artifacts.properties

* quote values of matrix params

* we can stack routes

* add tests with many different values

* remove changes not needed

* use server capability to choose the URL to build

* do not send headers if matrix_params capability

* do not add 'matrix_params' functionality to conan-server

* rename variable, 'file' is reserved

* remove change uneeded

* conan server does not support matrix params at all

* use the proper if/else

* Add res dir to the variables when using cmake_find_package. (issue 3722) (#6166)

* skip downloading call to to_file_bytes (#6142)

* warn if env-vars defined

* removed warning and env-vars

* remove another env-var
  • Loading branch information
memsharded authored and lasote committed Dec 3, 2019
1 parent 608ccb0 commit 8b170db
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 299 deletions.
2 changes: 0 additions & 2 deletions conans/client/cmd/export.py
Expand Up @@ -4,7 +4,6 @@

import six

from conans.client.cmd.export_linter import conan_linter
from conans.client.file_copier import FileCopier
from conans.client.output import Color, ScopedOutput
from conans.client.remover import DiskRemover
Expand Down Expand Up @@ -102,7 +101,6 @@ def cmd_export(app, conanfile_path, name, version, user, channel, keep_source,
logger.debug("EXPORT: %s" % conanfile_path)

output.highlight("Exporting package recipe")
conan_linter(conanfile_path, output)
output = conanfile.output

# Get previous digest
Expand Down
86 changes: 0 additions & 86 deletions conans/client/cmd/export_linter.py

This file was deleted.

5 changes: 0 additions & 5 deletions conans/client/conf/__init__.py
Expand Up @@ -123,9 +123,7 @@
# verbose_traceback = False # environment CONAN_VERBOSE_TRACEBACK
# error_on_override = False # environment CONAN_ERROR_ON_OVERRIDE
# bash_path = "" # environment CONAN_BASH_PATH (only windows)
# recipe_linter = False # environment CONAN_RECIPE_LINTER
# read_only_cache = True # environment CONAN_READ_ONLY_CACHE
# pylintrc = path/to/pylintrc_file # environment CONAN_PYLINTRC
# cache_no_locks = True # environment CONAN_CACHE_NO_LOCKS
# user_home_short = your_path # environment CONAN_USER_HOME_SHORT
# use_always_short_paths = False # environment CONAN_USE_ALWAYS_SHORT_PATHS
Expand Down Expand Up @@ -206,16 +204,13 @@ def env_vars(self):
"CONAN_COMPRESSION_LEVEL": self._env_c("general.compression_level", "CONAN_COMPRESSION_LEVEL", "9"),
"CONAN_NON_INTERACTIVE": self._env_c("general.non_interactive", "CONAN_NON_INTERACTIVE", "False"),
"CONAN_SKIP_BROKEN_SYMLINKS_CHECK": self._env_c("general.skip_broken_symlinks_check", "CONAN_SKIP_BROKEN_SYMLINKS_CHECK", "False"),
"CONAN_PYLINTRC": self._env_c("general.pylintrc", "CONAN_PYLINTRC", None),
"CONAN_CACHE_NO_LOCKS": self._env_c("general.cache_no_locks", "CONAN_CACHE_NO_LOCKS", "False"),
"CONAN_PYLINT_WERR": self._env_c("general.pylint_werr", "CONAN_PYLINT_WERR", None),
"CONAN_SYSREQUIRES_SUDO": self._env_c("general.sysrequires_sudo", "CONAN_SYSREQUIRES_SUDO", "False"),
"CONAN_SYSREQUIRES_MODE": self._env_c("general.sysrequires_mode", "CONAN_SYSREQUIRES_MODE", "enabled"),
"CONAN_REQUEST_TIMEOUT": self._env_c("general.request_timeout", "CONAN_REQUEST_TIMEOUT", None),
"CONAN_RETRY": self._env_c("general.retry", "CONAN_RETRY", None),
"CONAN_RETRY_WAIT": self._env_c("general.retry_wait", "CONAN_RETRY_WAIT", None),
"CONAN_VS_INSTALLATION_PREFERENCE": self._env_c("general.vs_installation_preference", "CONAN_VS_INSTALLATION_PREFERENCE", None),
"CONAN_RECIPE_LINTER": self._env_c("general.recipe_linter", "CONAN_RECIPE_LINTER", "True"),
"CONAN_CPU_COUNT": self._env_c("general.cpu_count", "CONAN_CPU_COUNT", None),
"CONAN_READ_ONLY_CACHE": self._env_c("general.read_only_cache", "CONAN_READ_ONLY_CACHE", None),
"CONAN_USER_HOME_SHORT": self._env_c("general.user_home_short", "CONAN_USER_HOME_SHORT", None),
Expand Down
10 changes: 10 additions & 0 deletions conans/pylint_plugin.py
Expand Up @@ -45,3 +45,13 @@ def transform_conanfile(node):
MANAGER.register_transform(
astroid.ClassDef, transform_conanfile,
lambda node: node.qname() == "conans.model.conan_file.ConanFile")


def _python_requires_member():
return astroid.parse("""
from conans.client.graph.python_requires import ConanPythonRequire
python_requires = ConanPythonRequire()
""")


astroid.register_module_extender(astroid.MANAGER, "conans", _python_requires_member)
5 changes: 0 additions & 5 deletions conans/requirements.txt
Expand Up @@ -8,14 +8,9 @@ fasteners>=0.14.1
six>=1.10.0,<1.13.0
node-semver==0.6.1
distro>=1.0.2, <1.2.0
pylint>=1.9.3, <2.0; python_version < '3'
pylint>=2.0,!=2.3.0; python_version >= '3'
future>=0.16.0, <0.19.0
pygments>=2.0, <3.0
astroid>=1.6.5, <2.0; python_version < '3'
astroid>=2.2.0; python_version >= '3'
deprecation>=2.0, <2.1
tqdm>=4.28.1, <5
Jinja2>=2.3, <3
python-dateutil>=2.7.0, <3
typed-ast<1.4; python_version == '3.4' and platform_system=='Windows'
176 changes: 0 additions & 176 deletions conans/test/functional/command/export_linter_test.py

This file was deleted.

0 comments on commit 8b170db

Please sign in to comment.