Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protobuf): Add an option to remove RTTI from binaries #4682

Merged
merged 4 commits into from Mar 10, 2021
Merged

feat(protobuf): Add an option to remove RTTI from binaries #4682

merged 4 commits into from Mar 10, 2021

Conversation

floriansimon1
Copy link
Contributor

@floriansimon1 floriansimon1 commented Feb 25, 2021

Protobuf (all versions)

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Before pulling this PR, let's make sure this Protobuf PR gets rejected.

@ericLemanissierBot
Copy link

ericLemanissierBot commented Feb 25, 2021

I detected other pull requests that are modifying protobuf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'protobuf/3.9.1' failed in build 1 (9c26e5abdb4bfc0d00c93bbacd1118861a3c06e4):

@uilianries
Copy link
Member

It seems be a feature for protobuff project, not a patch only for Conan. Could you open a PR to Upstream ?

@floriansimon1
Copy link
Contributor Author

Yes, I agree with you and I think it makes a lot of sense. Now, I just want to make sure of something: instead of having a "patch" of sorts, we want to have a clean CMake definition, correct?

@conan-center-bot
Copy link
Collaborator

Some configurations of 'protobuf/3.9.1' failed in build 2 (e2c8c34841c0cd763fd9c0ead47f5966f6f9e584):

@conan-center-bot
Copy link
Collaborator

All green in build 3 (e2c8c34841c0cd763fd9c0ead47f5966f6f9e584)! 😊

SSE4
SSE4 previously approved these changes Feb 26, 2021
@floriansimon1
Copy link
Contributor Author

Mmmh, why does it work now? I've been struggling all day yesterday trying to reproduce it with different compiler/configs, but I was never able to reproduce the issue. Any idea what changed? Was there a change in the master branch maybe?

@conan-center-bot
Copy link
Collaborator

All green in build 4 (e2c8c34841c0cd763fd9c0ead47f5966f6f9e584)! 😊

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the upstream decision.
If they merge, we can add similar change to the recipe.

recipes/protobuf/all/conanfile.py Outdated Show resolved Hide resolved
@floriansimon1
Copy link
Contributor Author

Good news folks! The change has been accepted upstream. So IIRC, I should have a new option that sets the CMake definition in the Conanfile.

For all versions before 3.16.0 (or whatever the version may be), if users request with_rtti=False, I should raise a ConanInvalidConfiguration?

@conan-center-bot
Copy link
Collaborator

Git error in build 5:

Could not checkout fb838b547bc1a78a21e422d55449255314dc0233

@conan-center-bot
Copy link
Collaborator

Failed in build 6:

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-4682/6/b2a02fba-5d4e-41c9-b836-6b6b98c0947a/.conan/remotes.json
ERROR: Error loading conanfile at '/home/conan/w/cci_PR-4682/recipes/protobuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/cci_PR-4682/recipes/protobuf/all/conanfile.py
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 197, in loads
    name, version, user, channel, revision = get_reference_fields(text)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 66, in get_reference_fields
    el1, el2 = _split_pair(arg_reference, "/") or (arg_reference, None)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 18, in _split_pair
    raise ConanException("The reference has too many '{}'".format(split_char))
conans.errors.ConanException: The reference has too many '/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/client/loader.py", line 389, in _parse_conanfile
    loaded = imp.load_source(module_id, conan_file_path)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/cci_PR-4682/recipes/protobuf/all/conanfile.py", line 24
    "with_zlib": [True, False],
              ^
SyntaxError: invalid syntax


@conan-center-bot
Copy link
Collaborator

Failure in build 7 (40ecceedb7bc03a8936d96af2a4455d550df7850):

  • protobuf/3.9.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.4" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.4". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • protobuf/3.11.4
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.4" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.4". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • protobuf/3.12.4
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.4" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.4". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • protobuf/3.13.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.4" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.4". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)

@floriansimon1
Copy link
Contributor Author

@uilianries > I know the SHA256 is not right. I will fix it as soon as I get it :)

@conan-center-bot
Copy link
Collaborator

Some configurations of 'protobuf/3.15.4' failed in build 8 (e3aa9b9d3fea2ee69e9727bf6868e1e005a1b86a):

@mathbunnyru
Copy link
Contributor

Good news folks! The change has been accepted upstream. So IIRC, I should have a new option that sets the CMake definition in the Conanfile.

For all versions before 3.16.0 (or whatever the version may be), if users request with_rtti=False, I should raise a ConanInvalidConfiguration?

You should delete this option for the versions which do not support it.
This is the safest way, it will not affect package_id in this case, which is a good thing.

@floriansimon1
Copy link
Contributor Author

floriansimon1 commented Mar 2, 2021

Good news folks! The change has been accepted upstream. So IIRC, I should have a new option that sets the CMake definition in the Conanfile.
For all versions before 3.16.0 (or whatever the version may be), if users request with_rtti=False, I should raise a ConanInvalidConfiguration?

You should delete this option for the versions which do not support it.
This is the safest way, it will not affect package_id in this case, which is a good thing.

On top of the ConanInvalidConfiguration thingy? Or instead of it?

If your answer to that question is "instead", wouldn't that be dangerous if users set it to False and end up with binaries with RTTI enabled?

@mathbunnyru
Copy link
Contributor

Good news folks! The change has been accepted upstream. So IIRC, I should have a new option that sets the CMake definition in the Conanfile.
For all versions before 3.16.0 (or whatever the version may be), if users request with_rtti=False, I should raise a ConanInvalidConfiguration?

You should delete this option for the versions which do not support it.
This is the safest way, it will not affect package_id in this case, which is a good thing.

On top of the ConanInvalidConfiguration thingy? Or instead of it?

If your answer to that question is "instead", wouldn't that be dangerous if users set it to False and end up with binaries with RTTI enabled?

You could add it on top if you want to, but it might be an overkill.
I would be fine having a check to be on the safest side possible.

This is an example, how you can delete options (just to make it easier for you):
https://github.com/conan-io/conan-center-index/blob/master/recipes/nlohmann_json/all/conanfile.py#L27

@floriansimon1
Copy link
Contributor Author

You could add it on top if you want to, but it might be an overkill.
I would be fine having a check to be on the safest side possible.

This is an example, how you can delete options (just to make it easier for you):
https://github.com/conan-io/conan-center-index/blob/master/recipes/nlohmann_json/all/conanfile.py#L27

I didn't know about config_options. It will indeed crash if users of versions prior to 3.15.4 define a with_rtti value, which is exactly what I wanted. Thanks for the suggestion!

@conan-center-bot
Copy link
Collaborator

Some configurations of 'protobuf/3.15.4' failed in build 9 (b8aab93beeb7095b0f29562fc95fb0cee2c8d5ce):

@floriansimon1 floriansimon1 marked this pull request as draft March 5, 2021 14:44
@conan-center-bot
Copy link
Collaborator

Failure in build 10 (b8aab93beeb7095b0f29562fc95fb0cee2c8d5ce):

  • protobuf/3.9.1@:
    All packages built successfully! (All logs)

  • protobuf/3.11.4@:
    All packages built successfully! (All logs)

  • protobuf/3.13.0@:
    An unexpected error happened and has been reported

  • protobuf/3.12.4@:
    All packages built successfully! (All logs)

  • protobuf/3.15.4@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@floriansimon1 floriansimon1 marked this pull request as ready for review March 8, 2021 15:38
@conan-center-bot
Copy link
Collaborator

Failure in build 11 (c42e63485b10ef414eddda5133577f8570b34698):

  • protobuf/3.9.1@:
    Error running command conan export "recipes/protobuf/all/conanfile.py" protobuf/3.9.1@:

    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 18.2626953125 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['CMakeLists.txt', 'patches/*']
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    
  • protobuf/3.11.4@:
    Error running command conan export "recipes/protobuf/all/conanfile.py" protobuf/3.11.4@:

    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 18.2626953125 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['CMakeLists.txt', 'patches/*']
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    
  • protobuf/3.12.4@:
    Error running command conan export "recipes/protobuf/all/conanfile.py" protobuf/3.12.4@:

    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 18.2626953125 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['CMakeLists.txt', 'patches/*']
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    
  • protobuf/3.13.0@:
    Error running command conan export "recipes/protobuf/all/conanfile.py" protobuf/3.13.0@:

    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 18.2626953125 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['CMakeLists.txt', 'patches/*']
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    
  • protobuf/3.15.4@:
    Error running command conan export "recipes/protobuf/all/conanfile.py" protobuf/3.15.4@:

    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 18.2626953125 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['CMakeLists.txt', 'patches/*']
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "3.15.5" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "3.15.5". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 12 (aa3ca2bc162bbb8b26f9902e080cf0d629da55f2):

  • protobuf/3.9.1@:
    All packages built successfully! (All logs)

  • protobuf/3.11.4@:
    All packages built successfully! (All logs)

  • protobuf/3.12.4@:
    All packages built successfully! (All logs)

  • protobuf/3.13.0@:
    All packages built successfully! (All logs)

  • protobuf/3.15.5@:
    CI failed to create some packages (All logs)

    Logs for packageID 337359dd1b2861192522303410ff239b857f902c:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libc++
    compiler.version=3.9
    os=Linux
    os_build=Linux
    [options]
    protobuf:shared=False
    
    [ 30%] Building CXX object source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.pb.cc.o
    source_subfolder/cmake/CMakeFiles/libprotobuf.dir/build.make:458: recipe for target 'source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.cc.o' failed
    [ 30%] Building CXX object source_subfolder/cmake/CMakeFiles/libprotobuf-lite.dir/__/src/google/protobuf/wire_format_lite.cc.o
    source_subfolder/cmake/CMakeFiles/libprotobuf.dir/build.make:471: recipe for target 'source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.pb.cc.o' failed
    CMakeFiles/Makefile2:172: recipe for target 'source_subfolder/cmake/CMakeFiles/libprotobuf.dir/all' failed
    [ 31%] Linking CXX static library ../../lib/libprotobuf-lite.a
    [ 31%] Built target libprotobuf-lite
    Makefile:148: recipe for target 'all' failed
    protobuf/3.15.5: 
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    In file included from /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.cc:36:
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/message.h:234:13: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
      constexpr Message() {}
                ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/message.h:234:13: note: non-literal type 'google::protobuf::MessageLite' cannot be used in a constant expression
    1 error generated.
    make[2]: *** [source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    In file included from /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.pb.cc:4:
    In file included from /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.pb.h:30:
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/message.h:234:13: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
      constexpr Message() {}
                ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/message.h:234:13: note: non-literal type 'google::protobuf::MessageLite' cannot be used in a constant expression
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.pb.cc:20:16: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
    constexpr Any::Any(
                   ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.pb.cc:20:16: note: non-literal type '::google::protobuf::Message' cannot be used in a constant expression
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.pb.cc:26:13: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
      constexpr AnyDefaultTypeInternal()
                ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/source_subfolder/src/google/protobuf/any.pb.cc:27:7: note: non-literal type 'google::protobuf::Any' cannot be used in a constant expression
        : _instance(::PROTOBUF_NAMESPACE_ID::internal::ConstantInitialized{}) {}
          ^
    3 errors generated.
    make[2]: *** [source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.pb.cc.o] Error 1
    make[1]: *** [source_subfolder/cmake/CMakeFiles/libprotobuf.dir/all] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make: *** [all] Error 2
    protobuf/3.15.5: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c
    protobuf/3.15.5: ERROR: Package '337359dd1b2861192522303410ff239b857f902c' build failed
    protobuf/3.15.5: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c
    ERROR: protobuf/3.15.5: Error in build() method, line 160
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/337359dd1b2861192522303410ff239b857f902c/build_subfolder' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

mathbunnyru
mathbunnyru previously approved these changes Mar 8, 2021
@conan-center-bot
Copy link
Collaborator

Failure in build 13 (aa3ca2bc162bbb8b26f9902e080cf0d629da55f2):

  • protobuf/3.9.1@:
    All packages built successfully! (All logs)

  • protobuf/3.11.4@:
    All packages built successfully! (All logs)

  • protobuf/3.12.4@:
    All packages built successfully! (All logs)

  • protobuf/3.13.0@:
    All packages built successfully! (All logs)

  • protobuf/3.15.5@:
    CI failed to create some packages (All logs)

    Logs for packageID 2f9c2f7bcaa7da67afebb3a748107518aa535123:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libstdc++
    compiler.version=3.9
    os=Linux
    os_build=Linux
    [options]
    protobuf:shared=False
    
    [ 30%] Linking CXX static library ../../lib/libprotobuf-lite.a
    [ 30%] Built target libprotobuf-lite
    [ 30%] Building CXX object source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/wire_format_lite.cc.o
    [ 31%] Building CXX object source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.cc.o
    [ 31%] Building CXX object source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.pb.cc.o
    source_subfolder/cmake/CMakeFiles/libprotobuf.dir/build.make:458: recipe for target 'source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.cc.o' failed
    source_subfolder/cmake/CMakeFiles/libprotobuf.dir/build.make:471: recipe for target 'source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.pb.cc.o' failed
    CMakeFiles/Makefile2:172: recipe for target 'source_subfolder/cmake/CMakeFiles/libprotobuf.dir/all' failed
    Makefile:148: recipe for target 'all' failed
    protobuf/3.15.5: 
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    In file included from /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.cc:36:
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/message.h:234:13: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
      constexpr Message() {}
                ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/message.h:234:13: note: non-literal type 'google::protobuf::MessageLite' cannot be used in a constant expression
    1 error generated.
    make[2]: *** [source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    In file included from /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.pb.cc:4:
    In file included from /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.pb.h:30:
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/message.h:234:13: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
      constexpr Message() {}
                ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/message.h:234:13: note: non-literal type 'google::protobuf::MessageLite' cannot be used in a constant expression
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.pb.cc:20:16: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
    constexpr Any::Any(
                   ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.pb.cc:20:16: note: non-literal type '::google::protobuf::Message' cannot be used in a constant expression
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.pb.cc:26:13: error: constexpr constructor never produces a constant expression [-Winvalid-constexpr]
      constexpr AnyDefaultTypeInternal()
                ^
    /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/source_subfolder/src/google/protobuf/any.pb.cc:27:7: note: non-literal type 'google::protobuf::Any' cannot be used in a constant expression
        : _instance(::PROTOBUF_NAMESPACE_ID::internal::ConstantInitialized{}) {}
          ^
    3 errors generated.
    make[2]: *** [source_subfolder/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/any.pb.cc.o] Error 1
    make[1]: *** [source_subfolder/cmake/CMakeFiles/libprotobuf.dir/all] Error 2
    make: *** [all] Error 2
    protobuf/3.15.5: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123
    protobuf/3.15.5: ERROR: Package '2f9c2f7bcaa7da67afebb3a748107518aa535123' build failed
    protobuf/3.15.5: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123
    ERROR: protobuf/3.15.5: Error in build() method, line 160
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/.conan/data/protobuf/3.15.5/_/_/build/2f9c2f7bcaa7da67afebb3a748107518aa535123/build_subfolder' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@mathbunnyru
Copy link
Contributor

@floriansimon1 the error doesn't seem to be random, so closing/opening PR won't help, you need to investigate the problem.

@prince-chrismc
Copy link
Contributor

Looks like they dropped clang 3 support

@floriansimon1
Copy link
Contributor Author

floriansimon1 commented Mar 9, 2021

@floriansimon1 the error doesn't seem to be random, so closing/opening PR won't help, you need to investigate the problem.

Yes, but I wanted to try a rebuild before wasting my time like last time where the failure was random and I spent a whole afternoon trying to replicate it.

@conan-center-bot
Copy link
Collaborator

All green in build 14 (8b0f82031d2dd5099e33bea3cece524f084950f3):

  • protobuf/3.9.1@:
    All packages built successfully! (All logs)

  • protobuf/3.15.5@:
    All packages built successfully! (All logs)

  • protobuf/3.11.4@:
    All packages built successfully! (All logs)

  • protobuf/3.12.4@:
    All packages built successfully! (All logs)

  • protobuf/3.13.0@:
    All packages built successfully! (All logs)

@floriansimon1
Copy link
Contributor Author

@uilianries > have your concerns been addressed?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not it looks good! Thank you!

@floriansimon1
Copy link
Contributor Author

@mathbunnyru > can you maybe validate those changes if you think they're fine please?

Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good 👍

@conan-center-bot conan-center-bot merged commit 2fd5a64 into conan-io:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants