coz: Causal profiler #3794

klimkin · 2020-12-04T02:08:28Z

Coz is a new kind of profiler that unlocks optimization opportunities
missed by traditional profilers. Coz employs a novel technique we call
causal profiling that measures optimization potential. This measurement
matches developers' assumptions about profilers: that optimizing
highly-ranked code will have the greatest impact on performance. Causal
profiling measures optimization potential for serial, parallel, and
asynchronous programs without instrumentation of special handling for
library calls and concurrency primitives. Instead, a causal profiler
uses performance experiments to predict the effect of optimizations.
This allows the profiler to establish causality: "optimizing function X
will have effect Y," exactly the measurement developers had assumed they
were getting all along.

https://github.com/plasma-umass/coz

Specify library name and version: coz/0.2.2

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Coz is a new kind of profiler that unlocks optimization opportunities missed by traditional profilers. Coz employs a novel technique we call causal profiling that measures optimization potential. This measurement matches developers' assumptions about profilers: that optimizing highly-ranked code will have the greatest impact on performance. Causal profiling measures optimization potential for serial, parallel, and asynchronous programs without instrumentation of special handling for library calls and concurrency primitives. Instead, a causal profiler uses performance experiments to predict the effect of optimizations. This allows the profiler to establish causality: "optimizing function X will have effect Y," exactly the measurement developers had assumed they were getting all along. https://github.com/plasma-umass/coz

recipes/coz/all/CMakeLists.txt

recipes/coz/all/conanfile.py

recipes/coz/all/test_package/CMakeLists.txt

recipes/coz/all/test_package/conanfile.py

klimkin · 2020-12-14T05:01:09Z

@prince-chrismc Thank you for prompt review. I will try to push CMake build upstream in the next two weeks.

klimkin · 2021-01-09T02:37:24Z

Making some progress here: plasma-umass/coz#178

stale · 2021-02-08T03:05:49Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

recipes/coz/all/conanfile.py

SpaceIm · 2021-05-28T10:36:34Z

recipes/coz/all/conanfile.py

+    __cmake = None
+
+    @property
+    def _cmake(self):
+        if self.__cmake is None:
+            self.__cmake = CMake(self)
+        return self.__cmake
+
+    def build(self):
+        self._cmake.configure()
+        self._cmake.build()
+
+    def package(self):
+        self._cmake.install()


we use another template usually, I don't say this one is bad, but it's harder to maintain when there are several conventions.

See 1d5defd

SpaceIm · 2021-05-28T10:40:25Z

recipes/coz/all/conanfile.py

+        if self.settings.os == "Linux":
+            self.cpp_info.system_libs = ["dl", "rt", "pthread"]


private dependencies, so probably useless because coz is always shared, but it doesn't hurt I guess

See 95b1852

recipes/coz/all/conanfile.py

recipes/coz/all/CMakeLists.txt

recipes/coz/all/conanfile.py

uilianries · 2021-06-08T20:08:10Z

@klimkin please, consider SpaceIm's review, so we are good to go.

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

conan-center-bot · 2021-06-08T22:44:37Z

All green in build 29 (95b185257b53f5cd20557a072f8300e27f80956c):

coz/cci.20210322@:
All packages built successfully! (All logs)

* coz: Causal profiler Coz is a new kind of profiler that unlocks optimization opportunities missed by traditional profilers. Coz employs a novel technique we call causal profiling that measures optimization potential. This measurement matches developers' assumptions about profilers: that optimizing highly-ranked code will have the greatest impact on performance. Causal profiling measures optimization potential for serial, parallel, and asynchronous programs without instrumentation of special handling for library calls and concurrency primitives. Instead, a causal profiler uses performance experiments to predict the effect of optimizations. This allows the profiler to establish causality: "optimizing function X will have effect Y," exactly the measurement developers had assumed they were getting all along. https://github.com/plasma-umass/coz * Cleanup config_options, since options.fPIC does not exist * Patch Python version * Disable incompatible Macos builds * Build test_package files with debug info * Implement code-review fixes * Use CMake from the package sources * Do not package lib/cmake * Pushed patch to upstream * Do not build for GCC version <5.0 * Require C++11 to match parent * Update recipes/coz/all/test_package/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/coz/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/coz/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/coz/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/coz/all/test_package/CMakeLists.txt Co-authored-by: Uilian Ries <uilianries@gmail.com> * Minor cleanup * Update recipes/coz/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Update recipes/coz/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Update recipes/coz/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Update recipes/coz/all/CMakeLists.txt Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use cmake template similar to other recipes * Remove private system_libs dependencies since building always shared Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Dec 4, 2020

Cleanup config_options, since options.fPIC does not exist

e80c263

This comment has been minimized.

Sign in to view

Patch Python version

f54c8ad

This comment has been minimized.

Sign in to view

Disable incompatible Macos builds

88606ec

klimkin force-pushed the feature/add-coz branch from 80e6bc6 to 88606ec Compare December 5, 2020 00:52

This comment has been minimized.

Sign in to view

Build test_package files with debug info

fbd4f2b

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Failed labels Dec 5, 2020

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Unexpected Error labels Dec 5, 2020

prince-chrismc reviewed Dec 5, 2020

View reviewed changes

recipes/coz/all/CMakeLists.txt Show resolved Hide resolved

prince-chrismc reviewed Dec 5, 2020

View reviewed changes

recipes/coz/all/CMakeLists.txt Outdated Show resolved Hide resolved

prince-chrismc reviewed Dec 5, 2020

View reviewed changes

recipes/coz/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Dec 5, 2020

View reviewed changes

recipes/coz/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Dec 5, 2020

View reviewed changes

recipes/coz/all/test_package/CMakeLists.txt Show resolved Hide resolved

prince-chrismc reviewed Dec 5, 2020

View reviewed changes

recipes/coz/all/test_package/conanfile.py Outdated Show resolved Hide resolved

Implement code-review fixes

a01c632

klimkin mentioned this pull request Jan 14, 2021

coz: Causal profiler #3282

Closed

4 tasks

stale bot added the stale label Feb 8, 2021

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label May 27, 2021

prince-chrismc previously approved these changes May 27, 2021

View reviewed changes

SSE4 previously approved these changes May 28, 2021

View reviewed changes

SpaceIm reviewed May 28, 2021

View reviewed changes

recipes/coz/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed May 28, 2021

View reviewed changes

recipes/coz/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed May 28, 2021

View reviewed changes

recipes/coz/all/CMakeLists.txt Outdated Show resolved Hide resolved

SpaceIm reviewed May 28, 2021

View reviewed changes

recipes/coz/all/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot requested review from uilianries and jgsogo June 1, 2021 12:01

klimkin dismissed stale reviews from SSE4 and prince-chrismc via 278e676 June 8, 2021 21:34

klimkin and others added 6 commits June 8, 2021 14:34

Update recipes/coz/all/conanfile.py

278e676

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Update recipes/coz/all/conanfile.py

b3b2c0b

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Update recipes/coz/all/conanfile.py

add55f5

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Update recipes/coz/all/CMakeLists.txt

898d5e8

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Use cmake template similar to other recipes

1d5defd

Remove private system_libs dependencies since building always shared

95b1852

SpaceIm approved these changes Jun 8, 2021

View reviewed changes

prince-chrismc approved these changes Jun 9, 2021

View reviewed changes

conan-center-bot requested a review from SSE4 June 9, 2021 11:57

danimtb approved these changes Jun 10, 2021

View reviewed changes

uilianries approved these changes Jun 10, 2021

View reviewed changes

conan-center-bot merged commit 1be2afb into conan-io:master Jun 10, 2021

adklimki deleted the feature/add-coz branch June 14, 2021 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

coz: Causal profiler #3794

coz: Causal profiler #3794

klimkin commented Dec 4, 2020 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

klimkin commented Dec 14, 2020

klimkin commented Jan 9, 2021

stale bot commented Feb 8, 2021

This comment has been minimized.

SpaceIm May 28, 2021

klimkin Jun 8, 2021

SpaceIm May 28, 2021

klimkin Jun 8, 2021

uilianries commented Jun 8, 2021

conan-center-bot commented Jun 8, 2021

		if self.settings.os == "Linux":
		self.cpp_info.system_libs = ["dl", "rt", "pthread"]

coz: Causal profiler #3794

coz: Causal profiler #3794

Conversation

klimkin commented Dec 4, 2020 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

klimkin commented Dec 14, 2020

klimkin commented Jan 9, 2021

stale bot commented Feb 8, 2021

This comment has been minimized.

SpaceIm May 28, 2021

Choose a reason for hiding this comment

klimkin Jun 8, 2021

Choose a reason for hiding this comment

SpaceIm May 28, 2021

Choose a reason for hiding this comment

klimkin Jun 8, 2021

Choose a reason for hiding this comment

uilianries commented Jun 8, 2021

conan-center-bot commented Jun 8, 2021

klimkin commented Dec 4, 2020 •

edited