Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland-protocols 1.21 #3663

Closed

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Nov 23, 2020

Specify library name and version: wayland-protocols/1.21

close #6946

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ericLemanissier ericLemanissier marked this pull request as draft November 23, 2020 08:49
@conan-center-bot

This comment has been minimized.

@ericLemanissier ericLemanissier mentioned this pull request Nov 24, 2020
4 tasks
@ericLemanissier ericLemanissier marked this pull request as ready for review November 26, 2020 10:39
@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

Here we go: this recipe only packages xml files, and it should generate the following .pc file:

prefix=/usr
datarootdir=${prefix}/share
pkgdatadir=${pc_sysrootdir}${datarootdir}/wayland-protocols

Name: Wayland Protocols
Description: Wayland protocol files
Version: 1.20

Which conan is currently not able to generate, because it has no way of specifying pkg-config variables.
We have to choose between:

  • making it a regular conan package, add it to KB-H014 allow list, and let consumer recipe patch the .pc file like this
  • making it a system package, but it's not very satisfying because we are able to compile it properly
  • don't make a package for wayland-procols, which means gtk package (regular package, not the system one currently available on CCI) will have to be built without wayland support by default
  • something else ?

@ericLemanissier
Copy link
Contributor Author

that's high level crickets!
@uilianries @SSE4 @Croydon wdyt ?

@Croydon
Copy link
Contributor

Croydon commented Dec 10, 2020

Urgh o.O

Is there any chance that pkg-config files can get a path to themselves, so we can construct a path that always works?

@ericLemanissier
Copy link
Contributor Author

I don't think so. the "regular package" solution would need something like conan-io/conan#4048 in order to patch the .pc file after install, or manual patching by consumers like bincrafters/conan-gtk@2ce2d80#diff-63f09721ade419d29886e8190ffa3c9c756baa9bef8802a7f2aeabf3b545164fR107-R108

@Croydon
Copy link
Contributor

Croydon commented Dec 11, 2020

I agree that this feels like it requires more Conan features.

Either we let Conan generate the .pc file and we get a correct prefix path to the package folder, but we won't have the custom variables then.

Or we package the .pc file and could define own variables, but there seems to be no way to guess the correct path after installation of the package.

@stale
Copy link

stale bot commented Jan 10, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2021
@ericLemanissier ericLemanissier mentioned this pull request Jan 11, 2021
4 tasks
@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Jan 11, 2021

Rethinking about this, I think the least bad option is to use a regular conan package, and rely on consumers (for now, that would be only gtk) to patch the generated wayland-protocols.pc and add the correct path in the pkgdatadir variable, or patch their build system to get the path to pkgdatadir from something else than pkg-config

@stale stale bot removed the stale label Jan 11, 2021
@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ericLemanissier
Copy link
Contributor Author

this is now blocked by the deployment of conan 1.36.0 now that conan-io/conan#8727 is merged

@stale stale bot removed the stale label Apr 29, 2021
@stale
Copy link

stale bot commented May 29, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 29, 2021
@stale stale bot removed the stale label Jun 7, 2021
@ericLemanissier ericLemanissier changed the title wayland-protocols 1.20 wayland-protocols 1.21 Jun 7, 2021
Automatically created by bincrafters-conventions 0.30.4
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericLemanissier ericLemanissier marked this pull request as draft June 17, 2021 09:33
@stale
Copy link

stale bot commented Jul 17, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 17, 2021
@ericLemanissier
Copy link
Contributor Author

blocked by conan-io/hooks#337

@stale stale bot removed the stale label Aug 16, 2021
@conan-center-bot

This comment has been minimized.

@ericLemanissier ericLemanissier marked this pull request as ready for review August 19, 2021 09:24
@ericLemanissierBot
Copy link

I detected other pull requests that are modifying wayland-protocols/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize about this PR and I've created mine here: #6946

I'm fine moving forward with any of them.


build_requires = (
"wayland/1.19.0"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed to build (at least using Meson) although the build-system declares the dependency.

url = "https://github.com/conan-io/conan-center-index"
homepage = "https://wayland.freedesktop.org/"
license = "MIT"
generators = "pkg_config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has no deps

Suggested change
generators = "pkg_config"

@conan-center-bot
Copy link
Collaborator

All green in build 10 (1e36717d9173dc1d47a0dcffa9512a12664daa4a):

  • wayland-protocols/1.21@:
    All packages built successfully! (All logs)

@ericLemanissier
Copy link
Contributor Author

When this recipe was originally written, wayland-protocols did not have meson support. Let's continue with the other PR

@ericLemanissier ericLemanissier deleted the wayland-protocols branch August 23, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants