New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wayland-protocols 1.21 #3663
wayland-protocols 1.21 #3663
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Here we go: this recipe only packages xml files, and it should generate the following .pc file:
Which conan is currently not able to generate, because it has no way of specifying pkg-config variables.
|
that's high level crickets! |
Urgh o.O Is there any chance that pkg-config files can get a path to themselves, so we can construct a path that always works? |
I don't think so. the "regular package" solution would need something like conan-io/conan#4048 in order to patch the .pc file after install, or manual patching by consumers like bincrafters/conan-gtk@2ce2d80#diff-63f09721ade419d29886e8190ffa3c9c756baa9bef8802a7f2aeabf3b545164fR107-R108 |
I agree that this feels like it requires more Conan features. Either we let Conan generate the Or we package the |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Rethinking about this, I think the least bad option is to use a regular conan package, and rely on consumers (for now, that would be only gtk) to patch the generated |
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
this is now blocked by the deployment of conan 1.36.0 now that conan-io/conan#8727 is merged |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Automatically created by bincrafters-conventions 0.30.4
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
blocked by conan-io/hooks#337 |
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying wayland-protocols/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize about this PR and I've created mine here: #6946
I'm fine moving forward with any of them.
|
||
build_requires = ( | ||
"wayland/1.19.0" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed to build (at least using Meson) although the build-system declares the dependency.
url = "https://github.com/conan-io/conan-center-index" | ||
homepage = "https://wayland.freedesktop.org/" | ||
license = "MIT" | ||
generators = "pkg_config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has no deps
generators = "pkg_config" |
All green in build 10 (
|
When this recipe was originally written, wayland-protocols did not have meson support. Let's continue with the other PR |
Specify library name and version: wayland-protocols/1.21
close #6946
conan-center hook activated.