-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rapidyaml: add version 0.6.0 #23837
base: master
Are you sure you want to change the base?
rapidyaml: add version 0.6.0 #23837
Conversation
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot :)
Minor comment about the handling of the new option, otherwise looks good
} | ||
default_options = { | ||
"shared": False, | ||
"fPIC": True, | ||
"with_default_callbacks": True, | ||
"with_tab_tokens": False, | ||
"with_default_callback_uses_exceptions": False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik this one should only be valid if with_default_callbacks
is true
as per biojppm/rapidyaml@v0.5.0...v0.6.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR17-R19 - we might need to delete the option in configure
if that is true
Specify library name and version: rapidyaml/0.6.0
biojppm/rapidyaml@v0.5.0...v0.6.0