-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: test_package for libjpeg #23712
refactor: test_package for libjpeg #23712
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying libjpeg/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's ok to remove test_v1_packages already, but otherwise looks good. Thanks! The test executable was doing way too much, indeed.
@@ -10,11 +10,3 @@ if (MSVC) | |||
target_compile_definitions(${PROJECT_NAME} PRIVATE _CRT_SECURE_NO_WARNINGS _CRT_NONSTDC_NO_WARNINGS) | |||
endif() | |||
|
|||
if(BUILD_TRANSUPP) | |||
add_executable(test_transupp test_transupp.c ${LIBJPEG_RES_DIR}/transupp.c) | |||
target_link_libraries(test_transupp PRIVATE JPEG::JPEG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably still test this minimally - this appears to be unconditionally included in the recipe.
perhaps just add an #include "transupp.h"
in test_package.c
and that's it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, but rest is great :D
Thanks @valgur! One of the goals of this PR is not only to simplify the test package, but to also remove any test that make use of binary files - these will no longer be accepted in any test package or in any PR. |
This comment has been minimized.
This comment has been minimized.
…/ErniGH/conan-center-index into erni/update-libjpeg-test_package
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 ( |
Simplify the test_package in according to our policies:
test_v1_package
and the image - it is not worth backporting the refactor to the legacy test