libftp: recipe improvements #23700
Merged
libftp: recipe improvements #23700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment has been minimized.
This comment has been minimized.
toge
approved these changes
Apr 22, 2024
Test that libftp provides OpenSSL routines.
deniskovalchuk
force-pushed
the
package/libftp
branch
from
441e91e
to
74bfc97
Compare
This comment has been minimized.
This comment has been minimized.
The test package must be compatible with v0.4.1.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
|
As far as I understand, the test package should be compatible with v0.4.1 so |
RubenRBS
approved these changes
Apr 23, 2024
You can if-def out code based on the version, but nevertheless I like the current simplicity better! :) |
toge
approved these changes
Apr 23, 2024
franramirez688
pushed a commit
to toge/conan-center-index
that referenced
this pull request
Apr 23, 2024
* libftp: update description * libftp: update topics * libftp: update test package Test that libftp provides OpenSSL routines. * libftp: avoid network operations in the test package * libftp: revert 2a51554 The test package must be compatible with v0.4.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libftp/0.5.0
Hi!
#23687 has added libftp v0.5.0 (thanks, @toge).
As FTPS support has been added in this version, I would like to suggest the
following improvements to the recipe:
Test that libftp provides OpenSSL routines.What do you think?