Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontconfig: Remove patch for freetype libtool version number #23010

Merged
merged 6 commits into from Apr 23, 2024
Merged

fontconfig: Remove patch for freetype libtool version number #23010

merged 6 commits into from Apr 23, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Mar 6, 2024 •
edited

This patch is a bad workaround for improper versioning in the freetype package. This is fixed in the freetype package itself in #22974.

In addition, this fixes the following error, which can be seen when running the test package for the Meson variant of the package:

Fontconfig error: Cannot load default config file: No such file: (null)

This is fixed by installing the fontconfig configuration file.
It was being installed to the wrong location in the Meson package previously.
Additionally, don't set FONTCONFIG_FILE, but instead append to FONTCONFIG_PATH only.
This works and makes it easier for consumers to opt for the system font directory.
See #5782.

Requires:

@jwillikers jwillikers mentioned this pull request Mar 6, 2024
Merged
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request Mar 13, 2024
Open
@prince-chrismc prince-chrismc mentioned this pull request Mar 13, 2024
Open
@RubenRBS RubenRBS self-assigned this Mar 14, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Mar 27, 2024
Open
Open
@ericLemanissierBot
Copy link

ericLemanissierBot commented Mar 27, 2024 •
edited

I detected other pull requests that are modifying fontconfig/meson recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ericLemanissierBot ericLemanissierBot mentioned this pull request Apr 8, 2024
Closed
3 tasks
@ericLemanissierBot
Copy link

I detected other pull requests that are modifying fontconfig/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ericLemanissierBot ericLemanissierBot mentioned this pull request Apr 13, 2024
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers
fontconfig: Remove patch for freetype libtool version number
0fb86d5 
This patch is a bad workaround for improper versioning in the freetype package.
This is fixed in the freetype package itself in conan-io#22974.
@jwillikers
Fix missing conf fontconfig file
4c0fa5a 
This fixes the following error, which can be seen when running the test package:

```
Fontconfig error: Cannot load default config file: No such file: (null)
```

This is fixed by installing the fontconfig configuration file.
It was being installed to the wrong location in the Meson package previously.
Additionally, don't set `FONTCONFIG_FILE`, but instead append to `FONTCONFIG_PATH` only.
This works and makes it easier for consumers to opt for the system font directory.
See conan-io#5782.
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Apr 22, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request Apr 23, 2024
Merged
3 tasks
ericLemanissier
ericLemanissier approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR seems to be urgent. LGTM

@ericLemanissier
Copy link
Contributor

The build is now finished. You can take a look at the results here

@jellespijker
Copy link
Contributor

thanks for helping out @ericLemanissier

jellespijker
jellespijker approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jwillikers
Copy link
Contributor Author

The build is now finished. You can take a look at the results here

I told the team yesterday to merge this immediately after the freetype one. I'll update it to at least get it building.

@jellespijker
Copy link
Contributor

I told the team yesterday to merge this immediately after the freetype one. I'll update it to at least get it building.

Out of curiosity, did you guys ever experimented with GitHub merge queue's? It's on my bucket list to investigate the usefulness for our project. It seems to be helpful for these kind of stacked PR's

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Apr 23, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit ed6f874
fontconfig/2.14.2@#4dea4eddccccabdaf8a666f69b3f2205 
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/workspace/prod-v1/bsr/30552/ccabc/.conan/data/fontconfig/2.14.2/_/_/package/1dd5f947341f0c35b104c3cbc22073e69527248e/res/share/xml/fontconfig/fonts.dtd' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/workspace/prod-v1/bsr/30552/ccabc/.conan/data/fontconfig/2.14.2/_/_/package/1dd5f947341f0c35b104c3cbc22073e69527248e/res/share/gettext/its/fontconfig.its' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/workspace/prod-v1/bsr/30552/ccabc/.conan/data/fontconfig/2.14.2/_/_/package/1dd5f947341f0c35b104c3cbc22073e69527248e/res/share/fontconfig/conf.avail/10-hinting-none.conf' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/workspace/prod-v1/bsr/30552/ccabc/.conan/data/fontconfig/2.14.2/_/_/package/1dd5f947341f0c35b104c3cbc22073e69527248e/res/etc/fonts/fonts.conf' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/workspace/prod-v1/bsr/30552/ccabc/.conan/data/fontconfig/2.14.2/_/_/package/1dd5f947341f0c35b104c3cbc22073e69527248e/res/etc/fonts/conf.d/51-local.conf' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (85a6b8953356c8a3712a05bddf1a7e700d374391):

  • fontconfig/2.14.2:
    All packages built successfully! (All logs)

  • fontconfig/2.13.93:
    All packages built successfully! (All logs)

  • fontconfig/2.15.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (85a6b8953356c8a3712a05bddf1a7e700d374391):

  • fontconfig/2.15.0:
    All packages built successfully! (All logs)

  • fontconfig/2.14.2:
    All packages built successfully! (All logs)

  • fontconfig/2.13.93:
    All packages built successfully! (All logs)

@jcar87 jcar87 self-assigned this Apr 23, 2024
@ericLemanissier
Copy link
Contributor

The build is now finished. You can take a look at the results here

jellespijker
jellespijker approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 560ac99 into conan-io:master Apr 23, 2024
23 checks passed
@jwillikers jwillikers deleted the fontconfig-freetype-version branch April 23, 2024 14:48
@jellespijker
Copy link
Contributor

jellespijker commented Apr 23, 2024 •
edited

Thanks everyone on behalf of team Cura for giving this PR priority.

It's appreciated ❤️ !

valgur
valgur reviewed Apr 24, 2024
View reviewed changes
recipes/fontconfig/meson/conanfile.py

import os

required_conan_version = ">=1.53.0"
required_conan_version = ">=1.64.0 <2 || >=2.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwillikers Why was this massive bump to the required Conan version necessary?

Related to conan-io/conan#16140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valgur valgur valgur left review comments

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

@jellespijker jellespijker jellespijker approved these changes

Assignees

@jcar87 jcar87

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jwillikers @conan-center-bot @ericLemanissierBot @ericLemanissier @jellespijker @valgur @franramirez688 @RubenRBS @jcar87