Package/ozz animation 0.14.1 #19191
Package/ozz animation 0.14.1 #19191
Conversation
|
I detected other pull requests that are modifying ozz-animation/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
| os.remove(os.path.join(self.package_folder, "LICENSE.md")) | ||
| os.remove(os.path.join(self.package_folder, "README.md")) | ||
| self.copy(pattern="LICENSE.md", dst="licenses", src=self._source_subfolder) | ||
| pkg = Path(self.package_folder) |
There was a problem hiding this comment.
| pkg = Path(self.package_folder) | |
| pkg = self.package_path |
There was a problem hiding this comment.
Interesting, I didn't realize that existed. Is it safe to use? It's not documented, and I noticed that no other recipes use it.
There was a problem hiding this comment.
It's somewhat new and undocumented, but should be safe to use:
conan-io/conan#11585 (comment)
| self.cpp_info.components[c].system_libs = ["m"] | ||
|
|
||
| self.cpp_info.components["base"].libs = [f"ozz_base{postfix}"] | ||
| self.cpp_info.components["base"].includedirs = ["include"] |
There was a problem hiding this comment.
| self.cpp_info.components["base"].includedirs = ["include"] |
Correct, but unnecessary. ["include"] is the default anyway.
| _build_subfolder = "build_subfolder" | ||
| def validate(self): | ||
| def _ensure_enabled(opt, req): | ||
| if getattr(self.options, opt): |
There was a problem hiding this comment.
| if getattr(self.options, opt): | |
| if self.options.get_safe(opt): |
Just a suggestion. getattr() is ok, too.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
Specify library name and version: ozz-animation/0.14.1
Add version 0.14.1 and update recipe to be compatible with Conan 2.0