Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cubicinterpolation: modernize for conan 2.0 #16299

Merged
merged 19 commits into from Apr 7, 2023
Merged

cubicinterpolation: modernize for conan 2.0 #16299

merged 19 commits into from Apr 7, 2023

Conversation

Jean1995
Copy link
Contributor

Specify library name and version: cubicinterpolation/0.1.x

Hello. With this PR, I've tried to update the conan recipe of cubicinterpolation to be compatible with Conan 2.0
For now, I've updated in such a way that it maintains compatibility with Conan 1.x, I hope this is accepted.
I've oriented myself on the cctag package (#13402) since this recipe has a similar structure.
I've updated it in such a way that it works for me with Conan 1.54.0 and Conan 2.0.

I'm happy about feedback, so I can continue working on modernizing my other package (proposal) soon :)

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Feb 26, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@Jean1995
Copy link
Contributor Author

Ok, at least the pipeline is working now.

@conan-center-bot

This comment has been minimized.

Sign in to view
@Jean1995
Copy link
Contributor Author

What are the next steps for me? 🙂

@conan-center-bot

This comment has been minimized.

Sign in to view
@Jean1995 Jean1995 mentioned this pull request Apr 2, 2023
Merged
3 tasks
@prince-chrismc
Copy link
Contributor

What are the next steps for me? 🙂

Wait for review! huge backlog of PRs with 2.0 so you'll need some patients... a month is kinda normal now https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md for the rest of the details :)

prince-chrismc
prince-chrismc reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks really good, just a handful of small comments to help update this even more!

recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated
if self.settings.compiler.get_safe("cppstd"):
check_min_cppstd(self, "14")

if str(self.settings.compiler) == "Visual Studio" and Version(self.settings.compiler.version) < "16":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.conan.io/2/reference/tools/microsoft/helpers.html?highlight=check%20min%20vs#conan.tools.microsoft.visual.check_min_vs

is raise = False would be better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_min_vs with raise_invalid=False has only been available since 1.57.0 (see #12880).

Should I just replace the block with a simple check_min_vs(self, 192)? Otherwise I would have to change the required_conan_version to >=1.57.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConanCenter recipes are always the latest (minus a version) Consumers are expected to be on 1.59 (sooner the later it will become 2.0) so it's absolutely allowed to increase the min version :)

recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/test_v1_package/test_package.cpp Outdated Show resolved Hide resolved
@Jean1995
Copy link
Contributor Author

Jean1995 commented Apr 4, 2023

What are the next steps for me? 🙂

Wait for review! huge backlog of PRs with 2.0 so you'll need some patients... a month is kinda normal now https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md for the rest of the details :)

Oh, I didn't know that the backlog was this immense, but it's understandable since there are over a thousand of packages... Thanks to everyone helping with this effort! 🙂

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc
Copy link
Contributor

I made prince-chrismc/conan-center-index-pending-review#1, there are some fun graphs at the bottom

we are down from about 150 PRs in review to just over 60 👏 working are way through

prince-chrismc
prince-chrismc reviewed Apr 4, 2023
View reviewed changes
recipes/cubicinterpolation/all/conandata.yml Outdated
sha256: "3151d99ecbbddd4e57605ff1919bdf234d08336b47d369b9dc562acff780aaf7"
patches:
"0.1.4":
- patch_file: "patches/patch_conanbuildinfo.txt"
base_path: "source_subfolder"
patch_type: "conan"
- patch_file: "patches/patch_conan_basic_setup.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind renaming this (and the old patch) to a .diff this way github will apply formating and it will be easier to read 🙏

patches/rm_conan_basic_setup.diff would be amazing 🤩

@conan-center-bot

This comment has been minimized.

Sign in to view
@Jean1995 Jean1995 mentioned this pull request Apr 5, 2023
Closed
@prince-chrismc
Copy link
Contributor

Amazing work!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 19 (a548b73486e0a0307f06fbdc660c238f06f475c7):

  • cubicinterpolation/0.1.3@:
    All packages built successfully! (All logs)

  • cubicinterpolation/0.1.4@:
    All packages built successfully! (All logs)

  • cubicinterpolation/0.1.5@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 18 (a548b73486e0a0307f06fbdc660c238f06f475c7):

  • cubicinterpolation/0.1.5@:
    All packages built successfully! (All logs)

  • cubicinterpolation/0.1.4@:
    All packages built successfully! (All logs)

  • cubicinterpolation/0.1.3@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4de26d0 into conan-io:master Apr 7, 2023
23 checks passed
MartinDelille pushed a commit to MartinDelille/conan-center-index that referenced this pull request Apr 12, 2023
@Jean1995 @prince-chrismc @MartinDelille
(conan-io#16299) cubicinterpolation: modernize for conan 2.0
687d7f2 
* compatability of cubic_interpolation with Conan 2.0

* missing newline

* use patch from new resource

* invalid use of patch

* adapt structure for patch

* add patch for older version of package

* safe delete of fPIC

* disable VS<16

* fix VS check

* add suggestions by @prince-chrismc

* update organization name

* clarify TODO in comment

* rename patch files and remove duplicate cpp file

* Apply suggestions from code review

---------

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jean1995 @conan-center-bot @prince-chrismc @SSE4