cyclonedds: lowercase systemlibs + modernize more + fix CMake config & pkgconfig file names #15437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix config file name - fix pkgconfig file name - bump iceoryx & openssl - require cmake only if recent version not available on build machine - more elegant removal of vc runtime files
SpaceIm
force-pushed
the
fix/cyclonedds-lowercase-systemlibs
branch
from
7ac5b78
to
f594a04
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit b78498acyclonedds/0.10.2 |
Conan v1 pipeline ✔️All green in build 8 (
|
jwillikers
approved these changes
Jan 25, 2023
1 task
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
…fix CMake config & pkgconfig file names * lowercase system libs * modernize more & few fixes - fix config file name - fix pkgconfig file name - bump iceoryx & openssl - require cmake only if recent version not available on build machine - more elegant removal of vc runtime files * lowercase sha256 * also remove pdb files * add libdl to system libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for conan-io/hooks#480
CMake config & pkgconfig file names are based on PROJECT_NAME which is CycloneDDS: https://github.com/eclipse-cyclonedds/cyclonedds/blob/0.10.2/CMakeLists.txt#L13
CMake config file name: https://github.com/eclipse-cyclonedds/cyclonedds/blob/0.10.2/CMakeLists.txt#L299-L303
pkgconfig file name: https://github.com/eclipse-cyclonedds/cyclonedds/blob/0.10.2/CMakeLists.txt#L314-L317