Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baical-p7: conan v2 support #15414

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 22, 2023

Specify library name and version: lib/1.0


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit fd4c0c3
baical-p7/5.6
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libp7-shared.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 23, 2023

It also fixes system libs casing (for conan-io/hooks#480)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 31, 2023

This PR has been triggered again because there are existing changes in master branch that are related to these same references resulting in different recipe-revisions. The build is being triggered on the PR context in case some additional fix is needed after merging those changes.

And it's not true, usually when I see this message everything breaks in CI.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (16fde07697b9119c28c377d8f4d0b8fa9112d127):

  • baical-p7/5.6@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

All green in build 5 (16fde07697b9119c28c377d8f4d0b8fa9112d127):

  • baical-p7/5.6@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 5b46a25 into conan-io:master Feb 1, 2023
@SpaceIm SpaceIm deleted the baical-p7-conan-v2 branch February 1, 2023 07:54
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* conan v2 support

* add libm to system libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants