Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: fix lib name on windows for other compilers than msvc/clang-cl/mingw #13597

Merged
merged 2 commits into from Oct 19, 2022
Merged

zlib: fix lib name on windows for other compilers than msvc/clang-cl/mingw #13597

merged 2 commits into from Oct 19, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 19, 2022

closes #13474

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@SpaceIm SpaceIm mentioned this pull request Oct 19, 2022
Closed
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Open
@conan-center-bot
Copy link
Collaborator

All green in build 1 (caa74fefc6e38afe43d32e5dc18c5fdb1c68af71):

  • zlib/1.2.13@:
    All packages built successfully! (All logs)

  • zlib/1.2.12@:
    All packages built successfully! (All logs)

  • zlib/1.2.11@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 5253b77 into conan-io:master Oct 19, 2022
@SpaceIm SpaceIm deleted the fix/zlib-win-clang branch October 19, 2022 14:32
@prince-chrismc prince-chrismc mentioned this pull request Oct 25, 2022
Closed
@Neustradamus
Copy link

@SpaceIm: Good job!

Cogitri pushed a commit to dampsoft/conan-center-index that referenced this pull request Nov 2, 2022
@SpaceIm @Cogitri
(conan-io#13597) zlib: fix lib name on windows for other compilers th…
82d79cf 
…an msvc/clang-cl/mingw

* fix lib name on windows if not cl like or mingw

* modernize a little bit more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@SpaceIm @conan-center-bot @Neustradamus @uilianries @jwillikers