Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add protobuf package version 3.21.4 #12079

Merged
merged 9 commits into from Aug 11, 2022
Merged

add protobuf package version 3.21.4 #12079

merged 9 commits into from Aug 11, 2022

Conversation

pgeler
Copy link
Contributor

@pgeler pgeler commented Aug 5, 2022 •
edited

Specify library name and version: protobuf/3.21.4

3.21.4 includes fix(3.21.3) for MSVC constint expression which is a showstopper from using grpc + msvc and c++17
https://github.com/protocolbuffers/protobuf/releases/tag/v21.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Aug 5, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissierBot ericLemanissierBot mentioned this pull request Aug 5, 2022
Open
@ericLemanissierBot
Copy link

I detected other pull requests that are modifying protobuf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Aug 5, 2022
Open
Open
@conan-center-bot conan-center-bot removed Failed Bump version PR bumping version without recipe modifications labels Aug 5, 2022
@github-actions github-actions bot mentioned this pull request Aug 5, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Hooks produced the following warnings for commit 60b6f63
protobuf/3.19.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.17.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.19.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.13.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.9.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.20.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.21.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.18.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.12.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.16.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.15.8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.15.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.11.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.21.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.

jellespijker added a commit to Ultimaker/CuraEngine that referenced this pull request Aug 8, 2022
@jellespijker
Update to protobuf 3.21.4
03141d3 
This contains a fix for the `constinit` on Visual Studio
with C++20. Although the version isn't in the conan-central-index
yet, we can user our own uploaded version Ultimaker/conan-center-index@3006672

Pushing these changes upstream seems to be not needed since there is
already another PR open. conan-io/conan-center-index#12079
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Use scm.Version
c2366b3 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Adopt new tools
47fa583 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries mentioned this pull request Aug 9, 2022
Merged
4 tasks
@uilianries
Copy link
Member

@pgeler Please, consider pgeler#2

@pgeler
Merge pull request #2 from uilianries/protobuf-3.21.4
cb67c47 
[protobuf] Adopt new Conan tools
@pgeler
Copy link
Contributor Author

pgeler commented Aug 9, 2022

@pgeler Please, consider pgeler#2

thank you @uilianries, I'm far away from conan2

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Hooks produced the following warnings for commit cb67c47
protobuf/3.21.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.15.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.20.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.19.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

All green in build 7 (f58856e5c6cb1d6efe4f8a5ae7fa95c82b2e7136):

  • protobuf/3.20.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py", line 8, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • protobuf/3.19.4@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py", line 8, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • protobuf/3.21.4@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py", line 8, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • protobuf/3.18.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py", line 8, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • protobuf/3.17.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12079/recipes/protobuf/all/conanfile.py", line 8, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit f58856e
protobuf/3.21.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.18.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.
protobuf/3.17.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotocd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotoc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobuf-lited.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libprotobufd.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries
uilianries approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit fd2811d into conan-io:master Aug 11, 2022
This was referenced Aug 11, 2022
Closed
Merged
Closed
Merged
SpaceIm
SpaceIm reviewed Aug 23, 2022
View reviewed changes
recipes/protobuf/all/conanfile.py
Comment on lines +297 to +301
for generator in ["cmake_find_package", "cmake_find_package_multi"]:
self.cpp_info.components["libprotobuf"].build_modules[generator] = build_modules
if self.options.lite:
self.cpp_info.components["libprotobuf-lite"].build_modules = build_modules
for generator in ["cmake_find_package", "cmake_find_package_multi"]:
self.cpp_info.components["libprotobuf-lite"].build_modules[generator] = build_modules
Copy link
Contributor

@SpaceIm SpaceIm Aug 23, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the reason of this regression #12474?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, build_modules should only be assigned to the root component (check 1.51 changelog - this PR)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_build_modules property is properly assigned to the root here.
build_modules is the legacy build modules, and it can't be assigned to root when there are components.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this is the reason why CONAN_BUILD_MODULES_PATHS_PROTOBUF is empty for cmake_paths (and others cmake_* generators too).
I don't really know if those cmake files were supposed to be there in the first place, but the problem is that protobuf_generate_cpp (which gets defined there) is pretty essential, so why would they not be?

@pgeler any reasoning for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@dubvulture dubvulture dubvulture left review comments

@SpaceIm SpaceIm SpaceIm left review comments

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pgeler @conan-center-bot @ericLemanissierBot @uilianries @jgsogo @dubvulture @SpaceIm