Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg: fix pkg_config generation #11813

Merged
merged 1 commit into from Jul 22, 2022

Conversation

ericLemanissier
Copy link
Contributor

fixes #11733

Specify library name and version: xorg/system

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ericLemanissierBot
Copy link

I detected other pull requests that are modifying xorg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ericLemanissierBot ericLemanissierBot mentioned this pull request Jul 20, 2022
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 1 (c0f831a5d584e2020150a8df0e5fedf8f891e245):

  • xorg/system@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11813/recipes/xorg/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11813/recipes/xorg/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11813/recipes/xorg/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

jwillikers added a commit to jwillikers/conan-center-index that referenced this pull request Jul 21, 2022
@q4a
Copy link

q4a commented Jul 22, 2022

Can somebody merge it?)

@ericLemanissier
Copy link
Contributor Author

We just need one more review before it is merged. Could you please take a look @jgsogo @SSE4 @toge @prince-chrismc ?
The issue this pr solves has already been reported twice

@conan-center-bot conan-center-bot merged commit f824ba2 into conan-io:master Jul 22, 2022
@ericLemanissier ericLemanissier deleted the patch-1 branch July 22, 2022 06:46
jwillikers added a commit to jwillikers/conan-center-index that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants