Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt/6: Bump openssl version #10050

Closed
wants to merge 7 commits into from

Conversation

MartinDelille
Copy link
Contributor

Specify library name and version: qt/6.x.x

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot conan-center-bot added the Bump dependencies Only bumping dependencies versions in the recipe label Mar 31, 2022
@ericLemanissierBot
Copy link

ericLemanissierBot commented Mar 31, 2022

I detected other pull requests that are modifying qt/6.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/qt/6.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/qt/6.x.x/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@PatSche PatSche mentioned this pull request Apr 5, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented Apr 6, 2022

I've checked it and harfbuzz/4.2.0 is available for those settings: https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/prod/TapaholesList/14/summary.json, but it computes a different packageID.

We need to know where does this packageID for harfbuzz comes from (1b94dda612e9a43ab30610d3a5a3f4483788d3a1), it should be some recipe modifying a default option value, or overriding some major version of some requirement.

ericLemanissier added a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 6, 2022
regenerate binaries for conan-io#10050
@ericLemanissier ericLemanissier mentioned this pull request Apr 6, 2022
4 tasks
conan-center-bot pushed a commit that referenced this pull request Apr 6, 2022
regenerate binaries for #10050
@MartinDelille MartinDelille reopened this Apr 6, 2022
AndreyMlashkin
AndreyMlashkin previously approved these changes Apr 6, 2022
@conan-center-bot

This comment has been minimized.

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
AndreyMlashkin
AndreyMlashkin previously approved these changes Apr 7, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Apr 11, 2022

you can also bump pcre2, glib, icu, libpq, sqlite3 & expat.

@ericLemanissier

This comment was marked as outdated.

@conan-center-bot conan-center-bot removed the Bump dependencies Only bumping dependencies versions in the recipe label Apr 11, 2022
@conan-center-bot
Copy link
Collaborator

Failure in build 11 (e8adad184a5a05c4a3ce5322524cfb5f9b83742d):

  • qt/6.1.3@:
    Didn't run or was cancelled before finishing

  • qt/6.0.4@:
    CI failed to create some packages (All logs)

    Logs for packageID 0e3dd5c90cbdf2f32869fd8bec838e4eee6f6cd0:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=16
    os=Windows
    [options]
    qt:shared=False
    
    [...]
    
          WrapSystemPCRE2_FOUND
    
      Condition values dump:
    
          WrapSystemPCRE2_FOUND = "FALSE"
    
    Call Stack (most recent call first):
      qtbase/cmake/QtFeature.cmake:355 (qt_feature_set_value)
      qtbase/cmake/QtFeature.cmake:155 (qt_evaluate_feature)
      qtbase/cmake/QtFeature.cmake:321 (qt_evaluate_config_expression)
      qtbase/cmake/QtFeature.cmake:542 (qt_evaluate_feature)
      qtbase/cmake/QtFeature.cmake:522 (qt_feature_module_end)
      qtbase/src/CMakeLists.txt:7 (qt_feature_evaluate_features)
    
    
    CMake Warning at qtbase/src/corelib/CMakeLists.txt:1204 (message):
      xmlstarlet was not found.  freedesktop.org.xml will not be minified!
    
    
    Generating Plugins files for EntryPoint;Core;Core_qobject;Concurrent;Sql;Network;Xml;Gui;OpenGL;Widgets;OpenGLWidgets;DeviceDiscoverySupport;FbSupport;Test;PrintSupport...
    Configuring 'qt5compat'
    Configuring 'qtsvg'
    Configuring 'qtdeclarative'
    Configuring 'qttools'
    Configuring 'qtquickcontrols2'
    Configuring 'qtdoc'
    Configuring 'qtshadertools'
    Configuring 'qtquick3d'
    Configuring 'qtquicktimeline'
    Configuring 'qttranslations'
    Configuring 'qtwayland'
    CMake Error at C:/J/w/prod/BuildSingleReference/.conan/data/cmake/3.22.0/_/_/package/0a420ff5c47119e668867cdb51baff0eca1fdb68/share/cmake-3.22/Modules/FeatureSummary.cmake:464 (message):
      feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
      run.
    Call Stack (most recent call first):
      qtbase/cmake/QtBuildInformation.cmake:4 (feature_summary)
      CMakeLists.txt:92 (qt_print_feature_summary)
    
    
    WARN: replace_in_file didn't find pattern '$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,MODULE_LIBRARY>:-Wl,--export-dynamic>' in 'FindZLIB.cmake' file.
    WARN: replace_in_file didn't find pattern ' IMPORTED)
    ' in 'FindZLIB.cmake' file.
    qt/6.0.4: ERROR: Package '0e3dd5c90cbdf2f32869fd8bec838e4eee6f6cd0' build failed
    qt/6.0.4: WARN: Build folder C:\J\w\prod\BuildSingleReference/s\3dec79\1
    ERROR: qt/6.0.4: Error in build() method, line 697
    	cmake = self._configure_cmake()
    while calling '_configure_cmake', line 647
    	self._cmake.configure(source_folder="qt6")
    	ConanException: Error 1 while executing cd C:\J\w\prod\BuildSingleReference/s\3dec79\1 && cmake -G "Ninja" -DCONAN_LINK_RUNTIME="/MD" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="Visual Studio" -DCONAN_COMPILER_VERSION="16" -DCONAN_CXX_FLAGS="/MP16" -DCONAN_C_FLAGS="/MP16" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="C:\J\w\prod\BuildSingleReference/s\478129\1" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_MODULE_PATH="C:/J/w/prod/BuildSingleReference/s/3dec79/1" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DINSTALL_MKSPECSDIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\archdatadir\mkspecs" -DINSTALL_ARCHDATADIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\archdatadir" -DINSTALL_LIBEXECDIR="C:\J\w\prod\BuildSingleReference/s\478129\1\bin" -DINSTALL_DATADIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\datadir" -DINSTALL_SYSCONFDIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\sysconfdir" -DQT_BUILD_TESTS="OFF" -DQT_BUILD_EXAMPLES="OFF" -DFEATURE_optimize_size="OFF" -DBUILD_qtsvg="OFF" -DBUILD_qtdeclarative="OFF" -DBUILD_qttools="OFF" -DBUILD_qttranslations="OFF" -DBUILD_qtdoc="OFF" -DBUILD_qtrepotools="OFF" -DBUILD_qtqa="OFF" -DBUILD_qtwayland="OFF" -DBUILD_qtquickcontrols2="OFF" -DBUILD_qtquicktimeline="OFF" -DBUILD_qtquick3d="OFF" -DBUILD_qtshadertools="OFF" -DBUILD_qt5compat="OFF" -DFEATURE_system_zlib="ON" -DINPUT_opengl="dynamic" -DINPUT_openssl="linked" -DFEATURE_dbus="OFF" -DFEATURE_glib="OFF" -DFEATURE_icu="OFF" -DFEATURE_fontconfig="OFF" -DFEATURE_sql_mysql="OFF" -DFEATURE_sql_psql="ON" -DFEATURE_sql_odbc="ON" -DFEATURE_gui="ON" -DFEATURE_widgets="ON" -DFEATURE_zstd="OFF" -DFEATURE_vulkan="OFF" -DFEATURE_brotli="ON" -DFEATURE_system_doubleconversion="ON" -DFEATURE_system_freetype="ON" -DFEATURE_system_harfbuzz="ON" -DFEATURE_jpeg="OFF" -DFEATURE_system_jpeg="OFF" -DFEATURE_system_png="ON" -DFEATURE_system_sqlite="ON" -DFEATURE_system_pcre2="ON" -DFEATURE_="OFF" -DQT_QMAKE_TARGET_MKSPEC="win32-msvc" -DFEATURE_pkg_config="ON" -Wno-dev C:\J\w\prod\BuildSingleReference/s\1a385c\1\qt6
    
  • qt/6.2.2@:
    Didn't run or was cancelled before finishing

  • qt/6.2.0@:
    Didn't run or was cancelled before finishing

  • qt/6.2.3@:
    Didn't run or was cancelled before finishing

  • qt/6.2.1@:
    Didn't run or was cancelled before finishing

  • qt/6.2.4@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@MartinDelille
Copy link
Contributor Author

There is this error on the log:

...
WARN: replace_in_file didn't find pattern '$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,SHARED_LIBRARY>:-Wl,--export-dynamic>' in 'FindZLIB.cmake' file.
Check dependencies of 'qtbase'
Configuring 'qtbase'
CMake Error at qtbase/cmake/QtFeature.cmake:277 (message):
  Feature "system_pcre2": Forcing to "ON" breaks its condition:

      WrapSystemPCRE2_FOUND

  Condition values dump:

      WrapSystemPCRE2_FOUND = "FALSE"

Call Stack (most recent call first):
  qtbase/cmake/QtFeature.cmake:355 (qt_feature_set_value)
  qtbase/cmake/QtFeature.cmake:155 (qt_evaluate_feature)
  qtbase/cmake/QtFeature.cmake:321 (qt_evaluate_config_expression)
  qtbase/cmake/QtFeature.cmake:542 (qt_evaluate_feature)
  qtbase/cmake/QtFeature.cmake:522 (qt_feature_module_end)
  qtbase/src/CMakeLists.txt:7 (qt_feature_evaluate_features)


CMake Warning at qtbase/src/corelib/CMakeLists.txt:1204 (message):
  xmlstarlet was not found.  freedesktop.org.xml will not be minified!


Generating Plugins files for EntryPoint;Core;Core_qobject;Concurrent;Sql;Network;Xml;Gui;OpenGL;Widgets;OpenGLWidgets;DeviceDiscoverySupport;FbSupport;Test;PrintSupport...
Configuring 'qt5compat'
Configuring 'qtsvg'
Configuring 'qtdeclarative'
Configuring 'qttools'
Configuring 'qtquickcontrols2'
Configuring 'qtdoc'
Configuring 'qtshadertools'
Configuring 'qtquick3d'
Configuring 'qtquicktimeline'
Configuring 'qttranslations'
Configuring 'qtwayland'
CMake Error at C:/J/w/prod/BuildSingleReference/.conan/data/cmake/3.22.0/_/_/package/0a420ff5c47119e668867cdb51baff0eca1fdb68/share/cmake-3.22/Modules/FeatureSummary.cmake:464 (message):
  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
  run.
Call Stack (most recent call first):
  qtbase/cmake/QtBuildInformation.cmake:4 (feature_summary)
  CMakeLists.txt:92 (qt_print_feature_summary)


WARN: replace_in_file didn't find pattern '$<$<STREQUAL:$<TARGET_PROPERTY:TYPE>,MODULE_LIBRARY>:-Wl,--export-dynamic>' in 'FindZLIB.cmake' file.
WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'FindZLIB.cmake' file.
qt/6.0.4: ERROR: Package '0e3dd5c90cbdf2f32869fd8bec838e4eee6f6cd0' build failed
qt/6.0.4: WARN: Build folder C:\J\w\prod\BuildSingleReference/s\3dec79\1
ERROR: qt/6.0.4: Error in build() method, line 697
	cmake = self._configure_cmake()
while calling '_configure_cmake', line 647
	self._cmake.configure(source_folder="qt6")
	ConanException: Error 1 while executing cd C:\J\w\prod\BuildSingleReference/s\3dec79\1 && cmake -G "Ninja" -DCONAN_LINK_RUNTIME="/MD" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="Visual Studio" -DCONAN_COMPILER_VERSION="16" -DCONAN_CXX_FLAGS="/MP16" -DCONAN_C_FLAGS="/MP16" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="C:\J\w\prod\BuildSingleReference/s\478129\1" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_MODULE_PATH="C:/J/w/prod/BuildSingleReference/s/3dec79/1" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DINSTALL_MKSPECSDIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\archdatadir\mkspecs" -DINSTALL_ARCHDATADIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\archdatadir" -DINSTALL_LIBEXECDIR="C:\J\w\prod\BuildSingleReference/s\478129\1\bin" -DINSTALL_DATADIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\datadir" -DINSTALL_SYSCONFDIR="C:\J\w\prod\BuildSingleReference/s\478129\1\res\sysconfdir" -DQT_BUILD_TESTS="OFF" -DQT_BUILD_EXAMPLES="OFF" -DFEATURE_optimize_size="OFF" -DBUILD_qtsvg="OFF" -DBUILD_qtdeclarative="OFF" -DBUILD_qttools="OFF" -DBUILD_qttranslations="OFF" -DBUILD_qtdoc="OFF" -DBUILD_qtrepotools="OFF" -DBUILD_qtqa="OFF" -DBUILD_qtwayland="OFF" -DBUILD_qtquickcontrols2="OFF" -DBUILD_qtquicktimeline="OFF" -DBUILD_qtquick3d="OFF" -DBUILD_qtshadertools="OFF" -DBUILD_qt5compat="OFF" -DFEATURE_system_zlib="ON" -DINPUT_opengl="dynamic" -DINPUT_openssl="linked" -DFEATURE_dbus="OFF" -DFEATURE_glib="OFF" -DFEATURE_icu="OFF" -DFEATURE_fontconfig="OFF" -DFEATURE_sql_mysql="OFF" -DFEATURE_sql_psql="ON" -DFEATURE_sql_odbc="ON" -DFEATURE_gui="ON" -DFEATURE_widgets="ON" -DFEATURE_zstd="OFF" -DFEATURE_vulkan="OFF" -DFEATURE_brotli="ON" -DFEATURE_system_doubleconversion="ON" -DFEATURE_system_freetype="ON" -DFEATURE_system_harfbuzz="ON" -DFEATURE_jpeg="OFF" -DFEATURE_system_jpeg="OFF" -DFEATURE_system_png="ON" -DFEATURE_system_sqlite="ON" -DFEATURE_system_pcre2="ON" -DFEATURE_="OFF" -DQT_QMAKE_TARGET_MKSPEC="win32-msvc" -DFEATURE_pkg_config="ON" -Wno-dev C:\J\w\prod\BuildSingleReference/s\1a385c\1\qt6

I've no idea how to solve this. If someone want to continue this PR which seems to be long waited for many people please do because I can't manage to dedicate more time to it.

if self.options.with_pcre2:
self.requires("pcre2/10.37")
self.requires("pcre2/10.39")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("pcre2/10.39")
self.requires("pcre2/10.37") # needs to be < 10.38

Woopsie, we already went through this one earlier in this PR 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to PCRE2Project/pcre2@2410fbe

I've left a comment few weeks ago to warn against this breaking change in static lib name for Visual Studio: PCRE2Project/pcre2@2410fbe#commitcomment-68176307

Copy link
Contributor

@SpaceIm SpaceIm Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it could be fixed in qt, the comment is misleading (it seems to say that pcre2 >= 10.38 is not compatible with qt, which is not true).

Instead of https://github.com/qt/qtbase/blob/v6.2.4/cmake/FindWrapSystemPCRE2.cmake#L27-L32:

  find_library(PCRE2_LIBRARY_RELEASE
              NAMES pcre2-16 pcre2-16-static
              HINTS ${PC_PCRE2_LIBDIR})
  find_library(PCRE2_LIBRARY_DEBUG
              NAMES pcre2-16d pcre2-16-staticd pcre2-16
              HINTS ${PC_PCRE2_LIBDIR})

@ericLemanissierBot ericLemanissierBot mentioned this pull request Apr 12, 2022
4 tasks
@ericLemanissier
Copy link
Contributor

@MartinDelille I integrated all your changes in #10261 so you can close this PR if you want.

@MartinDelille
Copy link
Contributor Author

Thanks @ericLemanissier ! I close it in favor of the promising #10261 then! 😄

@MartinDelille MartinDelille deleted the qt-bump-openssl branch April 12, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants