New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix glib compilation with msvc-clang #10029
fix glib compilation with msvc-clang #10029
Conversation
I don't think this is correct, what if i want to cross-compile using clang targeting Windows? |
In fact, a lot of recipes wrongly assume that you want to use clang-cl when specifying |
@SSE4 you seem to have created similar pull requests recently, thought you might want to know. |
I don't want to repeat myself, as explanation is pretty long. consider checking out #9807 (and maybe conan-io/conan#1839 as well). about
|
I would prefer going with the choice of putting these clang-cl pr/issues on hold and come up with a proper solution in Conan 2.0, due to not being a real correct way of dealing with these case as of now. I find this very ironic, thanks to clang being so flexible we don't seem to have proper a way of handling all of it's use cases. Another thing that i still haven't seen mentioned is that clang can be used in conjunction with mingw, and the target triplet of this configuration is |
I detected other pull requests that are modifying glib/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
is there already a concrete plan for conan 2.0? |
@AndreyMlashkin there is a conflict on this PR. Please, fix. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes some conflicts.
however, I don't think this should be merged before conan-io/conan#10955 is fixed, because "clang on windows" is not sufficient information to decide that we need to use VisualStudioBuildEnvironment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
All green in build 6 (
|
@AndreyMlashkin please change the PR status to draft |
I am in favor of a small change as long as it does not break the main workflows. We can always circle back to make it better |
There is no improvement here. It breaks one configuration to fix another |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: glib/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.