Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: passing fspath to from_parent #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Borda
Copy link

@Borda Borda commented Mar 14, 2023

fixing an error with probably latest ipython:

E   TypeError: from_parent() missing 1 required keyword-only argument: 'fspath'

@Borda
Copy link
Author

Borda commented Mar 15, 2023

@fangohr @takluyver @vidartf could you pls have look at the proposed hotfix? 🐰

@Borda
Copy link
Author

Borda commented Mar 24, 2023

Gentle ping @fangohr @takluyver @vidartf, and could you approve Ci run? 🐿️

@takluyver
Copy link
Member

takluyver commented Mar 24, 2023

What version of pytest are you seeing this with? Is there a full traceback of the error? The current code looks like fspath is optional:

https://github.com/pytest-dev/pytest/blob/172c832cbdbfa407087ed6a895a298b48984da2a/src/_pytest/nodes.py#L633-L640

@Borda
Copy link
Author

Borda commented Mar 24, 2023

he current code looks like fspath is optional

Yes, but in the new version, it raises a different error
see the comment with a trace: Lightning-AI/tutorials#222 (comment)

@takluyver
Copy link
Member

I think I'm looking at the newest version of that code. Can I ask you to check what version you're running? pytest --version

@Borda
Copy link
Author

Borda commented Mar 25, 2023

I think I'm looking at the newest version of that code. Can I ask you to check what version you're running? pytest --version

I had it in the log, but it seems that Azure keeps at most 2weeks' logs, and this is gone...
I may try to reproduce it but not sure when as I already had to switch to fork with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants