Test notebook for cells with a semicolon #195
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This notebook contains a cell where the output is suppressed with a semicolon. Nbval fails for this cell. The notebook was created with the most recent version of jupyter notebook. It was run from the top, saved and closed. How to reproduce: ``` pytest --nbval tests/semicolon.ipynb ``` What should happen: The test passes.
|
Btw, feel free to push into this PR if you like! |
|
See also #194. |
|
I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/computationalmodelling/nbval/pull/195 It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notebook contains a cell where the output is suppressed with a semicolon. Nbval fails for this cell.
The notebook was created with the most recent version of jupyter notebook. It was run from the top, saved and closed.
How to reproduce:
What should happen: The test passes.