COMCL-168: Fix linters workflow #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erawat
previously approved these changes
Jan 14, 2022
ahed-compucorp
changed the base branch from
COMCL-167-searchkit-error
to
master
ahed-compucorp
force-pushed
the
COMCL-168-fix-linters-workflow
branch
from
d7ef51e
to
718edbe
Compare
erawat
previously approved these changes
Jan 14, 2022
erawat
approved these changes
Jan 14, 2022
This was referenced Jan 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the failed linter workflow.
Technical Details
The
Set Correct NodeJS versionstep bootstraps the project withnvmso thatnvmwill install Node.js 14.16.0 which is specified in the file.nvmrc.The issue is the
Run npm installstep didn't use the version 14.16.0 and instead used the version 16.3.1.Here, I introduce the setup-node action which allows us to specify a Node.js version. It was created by the Github team.
Before using the action, we read the the version specified in the file
.nvmrcand set an output parameter so that the action can use it in the next step.