Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuelPHP: allow core, modules and packages to be installed #57

Closed
wants to merge 7 commits into from
Closed

FuelPHP: allow core, modules and packages to be installed #57

wants to merge 7 commits into from

Conversation

lukearmstrong
Copy link
Contributor

FuelPHP 1.6/develop has started using Composer for psr/log, monolog/monolog and fuelphp/upload
http://fuelphp.com/blogs/2013/01/fuelphp-and-composer-revisited

This pull request makes it possible for people using 1.6/develop to install core, modules and packages using composer. So whilst these things are not PSR compliant, starting to use composer now will hopefully make this transition much smoother and hopefully come around faster.

FuelPHP v1.x packages are prefixed with fuel-
FuelPHP v2.x packages are prefixed with fuelphp-, but FuelPHP v2 will not need to use composer/installers.

Here is the related pull request.
fuel/fuel#279

@lukearmstrong
Copy link
Contributor Author

Updated original pull request

PHPUnit 3.7.13 by Sebastian Bergmann.

Configuration read from /home/lukea/github/lukearmstrong/installers/phpunit.xml.dist

............................................................

Time: 0 seconds, Memory: 4.25Mb

OK (60 tests, 60 assertions)

@shama
Copy link
Contributor

shama commented Feb 5, 2013

Awesome, thanks @lukearmstrong! I'll get this merged shortly. The only part I would like to hold on is the core type. There are a couple other frameworks requesting a core type as well. I really want to get #43 implemented before. An install path without a package identifier means any package with that type could wipe out the path. I would like to test that scenario a little better. Hopefully I'll get some time (or some other generous person) to implement it soon.

@shama
Copy link
Contributor

shama commented Feb 6, 2013

Thanks again @lukearmstrong! I've merged fuel-module and fuel-package. Will merge fuel-core once #43 is implemented. So leaving this PR open.

@lukearmstrong
Copy link
Contributor Author

Thanks for merging fuel-module and fuel-package in.

Would you like me to look at implementing #43 if I find time?

@shama
Copy link
Contributor

shama commented Feb 7, 2013

Yes please! I'd appreciate that. Let me know if you have any questions.

@shama shama mentioned this pull request May 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants