Documenting custom-module and custom-theme types for Drupal. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documenting `custom-module` and `custom-theme` types for Drupal.
grasmash
changed the title
| @@ -52,7 +52,7 @@ is not needed to install packages with these frameworks: | |||
| | Decibel | `decibel-app` | |||
| | DokuWiki | `dokuwiki-plugin`<br>`dokuwiki-template` | |||
| | Dolibarr | `dolibarr-module` | |||
| | Drupal | <b>`drupal-core`<br>`drupal-module`<br>`drupal-theme`</b><br>`drupal-library`<br>`drupal-profile`<br>`drupal-drush` | |||
| | Drupal | <b>`drupal-core`<br>`drupal-module`<br>`drupal-theme`</b><br>`drupal-library`<br>`drupal-profile`<br>`drupal-drush`<br>`custom-module`<br>`custom-theme` | |||
There was a problem hiding this comment.
Maybe drupal-custom-module and drupal-custom-theme?
There was a problem hiding this comment.
I agree that would make more sense, but this pull request simply documents the values that already exist in code. Changing it at this point would be a backwards incompatible change and require a major version bump in order to follow semantic versioning.
|
Already done in #376. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting
custom-moduleandcustom-themetypes for Drupal.