Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command::execute() should always return an integer #8360

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Command::execute() should always return an integer #8360

merged 1 commit into from
Oct 8, 2019

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Oct 7, 2019

In Symfony 4.4, a deprecation error is triggered if Command::execute() does not return an integer, see symfony/symfony#33747. This PR adds the necessary return statements.

@Seldaek Seldaek merged commit 82d0b12 into composer:1.9 Oct 8, 2019
@Seldaek
Copy link
Member

Seldaek commented Oct 8, 2019

Thanks

@derrabus derrabus deleted the bugfix/execute-returns-0 branch October 8, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derrabus @Seldaek