Allow for SSH URLs when using hg repository type #11878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaxweb
force-pushed
the
main
branch
4 times, most recently
from
faa6ff0
to
c1f6491
Compare
stof
reviewed
Mar 11, 2024
stof
reviewed
Mar 12, 2024
|
Ok thanks for the PR. I did some more changes to the regex, hopefully you can check with latest composer snapshot that this is still working well for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ticket #11874
It was declared a feature, so I've chosen the main branch. I also applied a few minor fixups to docblocks for example. I hope that's ok, otherwise let me know and I'll remove them.
For the fix itself, I basically just adjusted the regex to allow "ssh" and to grab the password more reliably, even though the latter isn't even used. Worked fine with the repo I'm using, if the SSH key is set up in both the repo and the workstation you're issuing the pull from.