Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global Command tests #11769

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

franckranaivo
Copy link

Add Test for Global Command as it is required in #10796

This PR is still a work in progress as I try to acquire internal knowledge.

If anyone sees what is nice to test for the global command ;) , I'm open to suggestions.

@franckranaivo franckranaivo marked this pull request as draft December 22, 2023 08:30
@Seldaek Seldaek marked this pull request as ready for review January 10, 2024 16:32
@Seldaek
Copy link
Member

Seldaek commented Jan 10, 2024

I think we'd need to set up a global composer dir, you can do this by creating a temp dir in the tests and then setting Platform::putEnv('COMPOSER_HOME', the new temp dir) so it gets used as global dir then the global dir could be populated with some dependencies or whatever to make sure that we can use composer global show for example and it returns the stuff installed in the global dir.

As I wrote on the issue tho this is one of the most involved commands to test as it does some odd things internally.

@Seldaek Seldaek added this to the 2.7 milestone Jan 10, 2024
@Seldaek Seldaek modified the milestones: 2.7, 2.8 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants