Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'composer show --platform <package>' erroring without composer.json #11533

Merged
merged 1 commit into from Jul 21, 2023

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Jul 4, 2023

Sort of related to #11046 (although this is not a regression, but didn't work before, either)

This now skips output of the path field entirely (it previously was always empty)... fine IMO, since this could happen previously (e.g. if realpath() failed in case of JSON output), and the path has always been null anyway for platform packages.

Also think this should maybe get backported to 2.2? Would you like me to rebase on top of that branch instead of main? Or should I target 2.5?

… is present

Sort of related to composer#11046 (although this is not a regression, but didn't work before, either)
@Seldaek Seldaek added this to the 2.6 milestone Jul 21, 2023
@Seldaek Seldaek added the Bug label Jul 21, 2023
@Seldaek
Copy link
Member

Seldaek commented Jul 21, 2023

Thanks.

@Seldaek Seldaek merged commit 07f706e into composer:main Jul 21, 2023
17 of 18 checks passed
Seldaek pushed a commit that referenced this pull request Sep 28, 2023
… is present (#11533)

Sort of related to #11046 (although this is not a regression, but didn't work before, either)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants