Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure repos are always initialized with a repo manager if possible #10799

Merged
merged 1 commit into from May 24, 2022

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented May 24, 2022

[..] And make sure async is always enabled on the process executor, fixes #10783

@Seldaek Seldaek added the Bug label May 24, 2022
@Seldaek Seldaek added this to the 2.3 milestone May 24, 2022
…e, and make sure async is always enabled on the process executor, fixes composer#10783
@@ -118,8 +123,16 @@ public static function defaultRepos(IOInterface $io = null, Config $config = nul
* @param HttpDownloader $httpDownloader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated to HttpDownloader|null (or removed entirely as being redundant with the native signature)

Copy link
Member Author

@Seldaek Seldaek May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll remove all these redundant ones with php-cs-fixer at some point

@Seldaek Seldaek merged commit 88e1f0f into composer:2.3 May 24, 2022
@Seldaek Seldaek deleted the default_repo_fix branch May 24, 2022 19:34
emahorvat52 pushed a commit to emahorvat52/composer that referenced this pull request Feb 3, 2023
…e, and make sure async is always enabled on the process executor, fixes composer#10783 (composer#10799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants