Allow using temporary update constraints on all packages (incl non-root) #10773
+174
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2022
Seldaek
force-pushed
the
temp_constraints
branch
2 times, most recently
from
99508c1
to
e6a537a
Compare
stof
suggested changes
May 12, 2022
| if (!$found) { | ||
| foreach ($aliasedPackages as $index => $packageOrAlias) { | ||
| foreach ($packageAndAliases as $index => $packageOrAlias) { | ||
| unset($this->packages[$index]); |
There was a problem hiding this comment.
shouldn't the unsetting be done separately for each package depending on whether it matches or no ?
There was a problem hiding this comment.
I am not sure.. the package and its aliases are usually connected and have to be all installed or none. So here we keep the whole group if any of the aliased or alias matches the constraint, and if none match the whole thing is removed. I think this is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10436