Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native return types where possible #10547

Merged
merged 9 commits into from Feb 21, 2022
Merged

Add native return types where possible #10547

merged 9 commits into from Feb 21, 2022

Commits on Feb 18, 2022

  1. Add void types where no return statement is present

    @Seldaek
    Seldaek committed Feb 18, 2022
    Copy the full SHA
    abdc689 View commit details
    Browse the repository at this point in the history

  2. Add return types to private/internal methods

    @Seldaek
    Seldaek committed Feb 18, 2022
    Copy the full SHA
    a16ed3d View commit details
    Browse the repository at this point in the history

  3. Clean up useless mocks

    @Seldaek
    Seldaek committed Feb 18, 2022
    Copy the full SHA
    137ebdd View commit details
    Browse the repository at this point in the history

  4. Add return types to all code which is not being extended by open sour… 

    …ce packages
    @Seldaek
    Seldaek committed Feb 18, 2022
    Copy the full SHA
    eda9014 View commit details
    Browse the repository at this point in the history

  5. Split Composer into PartialComposer & Composer classes to avoid nulla… 

    …ble properties on Composer for non-fully-loaded instances, add types to Composer\Factory
    @Seldaek
    Seldaek committed Feb 18, 2022
    Copy the full SHA
    84f0f19 View commit details
    Browse the repository at this point in the history

  6. Remove alias::getAliasOf return type as this is not compatible with P… 

    …HP 7.2/7.3
    @Seldaek
    Seldaek committed Feb 18, 2022
    Copy the full SHA
    7b1fc4b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Add return types to closures (#9)

    @alexander-schranz
    alexander-schranz committed Feb 21, 2022
    Copy the full SHA
    1321bfc View commit details
    Browse the repository at this point in the history

  2. Add return types to tests (#10)

    @alexander-schranz
    alexander-schranz committed Feb 21, 2022
    Copy the full SHA
    e9b6058 View commit details
    Browse the repository at this point in the history

  3. Update phpstan config

    @Seldaek
    Seldaek committed Feb 21, 2022
    Copy the full SHA
    fb854df View commit details
    Browse the repository at this point in the history