Fix licenses summary with missing license info #10536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to PHP 7.2+
Cleanup PHP 5.3 hacks and legacy TODOs
…onstants, and TlsHelper
…d files are kept as is for BC
Deprecations & more php version cleanups
Allow xdebug-handler 3.x, update deps
semver.mwl.be returns a permanent redirect to semver.madewithlove.com
Co-authored-by: Houssem ZITOUN <houssem.zitoun@ekino.com>
…10485) To synchronize `abandoned` information with JSON APIs and the `composer.json` information of a package, we should return the following types: `bool|non-empty-string`. This will either state if a package is abandoned and, if there is a replacement declared, what replacement package should be used instead. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Fixes the issue of license summary command aborting when a package is missing license information.
composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
|
I based this on the wrong branch, so I made a new PR here: #10537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the LicensesCommand fails, when getting the summary (-f summary) and one of the packages is missing the license information.
This fixes the issue by simply using 'none' as the license, as is used in the text output already.