Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for update reference in path repository #10488

Merged
merged 3 commits into from Feb 7, 2022

Conversation

sveneld
Copy link
Contributor

@sveneld sveneld commented Jan 27, 2022

Example of composer.json

{
  "name": "example/example",
  "require": {
    "pathExample/example": "^1.0"
  },
  "repositories": [
    {
      "type": "path",
      "url": "./pathExample"
    }
  ]  
}

Source code in folder pathExample is under git version control and offently updated by developers, and after each update "reference" in composer.lock for this package is update, but it caused a conflict between different branches. So it will be great to have opportunity to configure reference updating like this

{
  "name": "example/example",
  "require": {
    "pathExample/example": "^1.0"
  },
  "repositories": [
    {
      "type": "path",
      "url": "./pathExample",
      "reference": "none"
    }
  ]  
}

Related to #10482

@sveneld sveneld force-pushed the feature/path-repository-reference branch 2 times, most recently from 1a7e399 to 2196373 Compare January 31, 2022 06:16
@Seldaek Seldaek added this to the 2.3 milestone Feb 2, 2022
@Seldaek Seldaek added the Feature label Feb 2, 2022
@sveneld sveneld force-pushed the feature/path-repository-reference branch from 2196373 to 9657f81 Compare February 3, 2022 14:40
@private-packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@sveneld sveneld force-pushed the feature/path-repository-reference branch from 9657f81 to 693da50 Compare February 3, 2022 14:42
@sveneld sveneld force-pushed the feature/path-repository-reference branch 2 times, most recently from 840e35a to 914e966 Compare February 3, 2022 15:02
@Seldaek
Copy link
Member

Seldaek commented Feb 3, 2022

Thanks. The other bonus thing would be to add this new option to the docs of the path repo in doc/05-repositories.md :)

@sveneld sveneld force-pushed the feature/path-repository-reference branch from 914e966 to efaf6cb Compare February 3, 2022 15:04
@sveneld
Copy link
Contributor Author

sveneld commented Feb 3, 2022

Ok. tomorrow :)

@Seldaek
Copy link
Member

Seldaek commented Feb 3, 2022

No rush :)

@sveneld sveneld force-pushed the feature/path-repository-reference branch from efaf6cb to 321016c Compare February 6, 2022 11:04
@sveneld sveneld force-pushed the feature/path-repository-reference branch from 37a1d84 to 60da7c0 Compare February 6, 2022 11:12
@sveneld
Copy link
Contributor Author

sveneld commented Feb 6, 2022

Done

@Seldaek
Copy link
Member

Seldaek commented Feb 7, 2022

Thanks!

@Seldaek Seldaek merged commit a0b0ddc into composer:main Feb 7, 2022
@sveneld sveneld deleted the feature/path-repository-reference branch February 8, 2022 07:16
emahorvat52 pushed a commit to emahorvat52/composer that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants