Deprecations & more php version cleanups #10428
Conversation
Seldaek
commented
Jan 4, 2022
Seldaek
commented
- Fixes the last bits of Drop support for older PHP releases #9303 and introduces a few deprecations (JsonFormatter, JsonFile::* constants, TlsHelper)
- Drops PHP <7.2, HHVM and ZendGuard (as it never supported PHP 7+) support from autoload_real, so that autoload_static.php is always used. Other files are kept for BC as I suspect other tooling may rely on them. I do not plan on removing them for now.
- Closes dirname(__FILE__) no longer needed #9433 as it is included in this PR, which fixes End of php52 supporting #9224 too
…onstants, and TlsHelper
…d files are kept as is for BC
| @@ -981,7 +980,7 @@ public static function getLoader() | |||
|
|
|||
| $file .= <<<CLASSLOADER_INIT | |||
| spl_autoload_register(array('ComposerAutoloaderInit$suffix', 'loadClassLoader'), true, $prependAutoloader); | |||
| self::\$loader = \$loader = new \\Composer\\Autoload\\ClassLoader(\\dirname(\\dirname(__FILE__))); | |||
There was a problem hiding this comment.
Is there any reason why dirname(dirname(__FILE__)) was replaced by just dirname(__DIR__) ? It looks like this is breaking with version 2.3.0 of Composer for autoload.files for us. Currently investigating - will add a ticket as soon as i got more information, but curious about that change 🤔
Edit: Looks like related to #9433
There was a problem hiding this comment.
Because dirname(__FILE__) is the equivalent of __DIR__? So this should not be an issue. Most likely you'ae having issues due to #10617 perhaps? Check if you can repro with 2.2.10 as well, and if 2.2.7 fixes it?
composer self-update 2.2.7 for example to downgrade to a specific version.
There was a problem hiding this comment.
Thanks for the very fast reply! 💪
It looks like that not this is the problem. Also, with Composer 2.2.10 it is working again.
The problem for us is, that we're using our custom Composer Plugin https://github.com/inpsyde/vip-composer-plugin , which replaces the paths in those autoload_*.php files. But it seems those files are not used anymore in Composer v2.3.?
