Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't revert composer.json when "require" fails because of scripts #10118

Closed
wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Contributor

@Seldaek
Copy link
Member

Seldaek commented Oct 1, 2021

I agree we should fix this as it's annoying, but I wonder if we could target only post-update scripts failures somehow.. Because if some script fails earlier than when the update is complete, we probably still want to revert.

@imme-emosol
Copy link
Contributor

Would that be after

$this->eventDispatcher->dispatchScript($eventName, $this->devMode);
?

@Seldaek
Copy link
Member

Seldaek commented Oct 13, 2021

Let's say it'd be ok if anything fails from that point on (POST_UPDATE_CMD), but before that it should still revert IMO.

@Seldaek Seldaek closed this in 759a3a9 Oct 14, 2021
@Seldaek
Copy link
Member

Seldaek commented Oct 14, 2021

OK I think I found a relatively accurate way to fix this :)

@dzuelke
Copy link
Contributor

dzuelke commented Feb 17, 2022

@nicolas-grekas could you please check that #10541 does not break this (and symfony/flex#142) again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants