Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit: move environment variable into PHPUnit config file #10062

Merged
merged 3 commits into from Aug 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/CONTRIBUTING.md
Expand Up @@ -42,9 +42,14 @@ To achieve this, you need to acquire the Composer source code:
3. Run Composer to get the dependencies: `cd composer && php ../composer.phar install`

You can run the test suite by executing `vendor/bin/simple-phpunit` when inside the
composer directory, and run Composer by executing the `bin/composer`. To test
your modified Composer code against another project, run `php
/path/to/composer/bin/composer` inside that project's directory.
composer directory, and run Composer by executing the `bin/composer`.

For running the tests against the most recent PHP versions (PHP 8.0/8.1), you will
need to run `composer update --ignore-platform-reqs && git checkout composer.lock` before running
the `vendor/bin/simple-phpunit` command.

To test your modified Composer code against another project, run
`php /path/to/composer/bin/composer` inside that project's directory.

Contributing policy
-------------------
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/continuous-integration.yml
Expand Up @@ -12,7 +12,6 @@ env:
COMPOSER_FLAGS: "--ansi --no-interaction --no-progress --prefer-dist"
COMPOSER_UPDATE_FLAGS: ""
COMPOSER_TESTS_ARE_RUNNING: "1"
SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT: "1"

jobs:
tests:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -4,6 +4,7 @@
/composer.phar
/vendor
/nbproject
.phpunit.result.cache
phpunit.xml
.vagrant
Vagrantfile
Expand Down
1 change: 1 addition & 0 deletions phpunit.xml.dist
Expand Up @@ -16,6 +16,7 @@
>
<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=0"/>
<env name="SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT" value="1"/>
<env name="COMPOSER_TEST_SUITE" value="1"/>
</php>
<testsuites>
Expand Down
1 change: 1 addition & 0 deletions tests/complete.phpunit.xml
Expand Up @@ -16,6 +16,7 @@
>
<php>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="weak"/>
<env name="SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT" value="1"/>
</php>
<testsuites>
<testsuite name="Full Composer Test Suite">
Expand Down