Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review/add visibility on all constants #10550

Closed
Seldaek opened this issue Feb 18, 2022 · 2 comments
Closed

Review/add visibility on all constants #10550

Seldaek opened this issue Feb 18, 2022 · 2 comments
Assignees
@Seldaek
Labels
Refactoring
Milestone
2.3

Comments

@Seldaek
Copy link
Member

Seldaek commented Feb 18, 2022

No description provided.

@Seldaek Seldaek added this to the 2.3 milestone Feb 18, 2022
@Seldaek Seldaek self-assigned this Feb 18, 2022
@localheinz
Copy link
Contributor

See https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.6.0/doc/rules/class_notation/visibility_required.rst!

@Seldaek
Copy link
Member Author

Seldaek commented Feb 19, 2022

Yup I got this one in the php CS fixer config ready to go already, but the task here is to figure out which can be marked private, I'd rather not leave it all public if it doesnt need to be :)

Seldaek added a commit to Seldaek/composer that referenced this issue Feb 23, 2022
@Seldaek
Add visibility to all consts, fixes composer#10550

Verified

This commit was signed with the committer’s verified signature.
Seldaek Jordi Boggiano
GPG key ID: 7BBD42C429EC80BC
Verified
Learn about vigilant mode
113633d
Seldaek added a commit that referenced this issue Feb 23, 2022
@Seldaek
Merge pull request #10565 from Seldaek/add_const_visibility

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1e914f8 
Add visibility to all consts, fixes #10550
@dkreuer dkreuer mentioned this issue Mar 31, 2022
Closed
emahorvat52 pushed a commit to emahorvat52/composer that referenced this issue Feb 3, 2023
@Seldaek @emahorvat52
Add visibility to all consts, fixes composer#10550

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
c840a1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Seldaek Seldaek

Labels
Refactoring
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@Seldaek @localheinz